Change ACCELERATED_COMPOSITING blacklist to GPU_COMPOSITING.

extensions/common/manifest_handlers/requirements_info.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest_handlers/requirements_info.h"
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/manifest_constants.h"
 
 namespace extensions {
 
 namespace keys = manifest_keys;
 namespace errors = manifest_errors;
 
 RequirementsInfo::RequirementsInfo(const Manifest* manifest)
     : webgl(false),
-      css3d(false),
       npapi(false),
       window_shape(false) {
   // Before parsing requirements from the manifest, automatically default the
   // NPAPI plugin requirement based on whether it includes NPAPI plugins.
   const base::ListValue* list_value = NULL;
   npapi = manifest->GetList(keys::kPlugins, &list_value) &&
           !list_value->empty();
 }
 
 RequirementsInfo::~RequirementsInfo() {
@@ skipping 81 matching lines @@
             errors::kInvalidRequirement, iter.key());
         return false;
       }
 
       for (base::ListValue::const_iterator feature_iter = features->begin();
            feature_iter != features->end(); ++feature_iter) {
         std::string feature;
         if ((*feature_iter)->GetAsString(&feature)) {
           if (feature == "webgl") {
             requirements->webgl = true;
-          } else if (feature == "css3d") {

[Marijn Kruisselbrink, 2014/04/16 20:39:14]

Removing this if entirely makes this a backwards incompatible change. Extensions
that specify the css3d requirement would now always give an error (since now the
else below would be reached). I think the right thing to do would be to silently
ignore (but not reject) the css3d feature? (at least I understand that now what
the css3d feature specified will always be available)

[danakj, 2014/04/16 20:46:57]

oh ok that was what I was attempting to do yes. i guess i messed that up here. 

[danakj, 2014/04/16 20:54:11]

I'm trying to understand what the right thing to do here is. I don't see "css3d"
or even "3D" in the manifest_constants.cc file. Would branching and doing
nothing here be the right thing? Should I leave this code alone and just change
the RequirementsChecker?

-            requirements->css3d = true;
           } else {
             *error = ErrorUtils::FormatErrorMessageUTF16(
                 errors::kInvalidRequirement, iter.key());
             return false;
           }
         }
       }
     } else if (iter.key() == "window") {
       for (base::DictionaryValue::Iterator feature_iter(*requirement_value);
            !feature_iter.IsAtEnd(); feature_iter.Advance()) {
@@ skipping 15 matching lines @@
       *error = base::ASCIIToUTF16(errors::kInvalidRequirements);
       return false;
     }
   }
 
   extension->SetManifestData(keys::kRequirements, requirements.release());
   return true;
 }
 
 }  // namespace extensions