src/heap.h - Issue 239083005: Callers of Heap::AllocateStringFromOneByte() and Heap::AllocateStringFromUtf8() handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.h

Issue 239083005: Callers of Heap::AllocateStringFromOneByte() and Heap::AllocateStringFromUtf8() handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.h

diff --git a/src/heap.h b/src/heap.h

index 869ea3ee1d78110af9969cd378a126a6fbf9da39..e4e89412d21958f3749269823278bfa3168e625c 100644

--- a/src/heap.h

+++ b/src/heap.h

@@ -788,16 +788,6 @@ class Heap {

MUST_USE_RESULT MaybeObject* AllocateStringFromOneByte(

Vector<const uint8_t> str,

PretenureFlag pretenure = NOT_TENURED);

- // TODO(dcarney): remove this function.

- MUST_USE_RESULT inline MaybeObject* AllocateStringFromOneByte(

- Vector<const char> str,

- PretenureFlag pretenure = NOT_TENURED) {

- return AllocateStringFromOneByte(Vector<const uint8_t>::cast(str),

- pretenure);

- }

- MUST_USE_RESULT inline MaybeObject* AllocateStringFromUtf8(

- Vector<const char> str,

- PretenureFlag pretenure = NOT_TENURED);

MUST_USE_RESULT MaybeObject* AllocateStringFromUtf8Slow(

Vector<const char> str,

int non_ascii_start,

« no previous file with comments | « src/factory.cc ('k') | src/heap-inl.h » ('j') | no next file with comments »