Issue 239083005: Callers of Heap::AllocateStringFromOneByte() and Heap::AllocateStringFromUtf8() handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239083005: Callers of Heap::AllocateStringFromOneByte() and Heap::AllocateStringFromUtf8() handlified. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Callers of Heap::AllocateStringFromOneByte() and Heap::AllocateStringFromUtf8() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20821

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -38 lines)			Patch
M	src/factory.cc	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	src/heap.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/heap-inl.h	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/runtime.cc	View	1	7 chunks	+13 lines, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

Yang

Lgtm. For const strings you couls actually use STATIC_ASCII_VECTOR and use the vector version.

6 years, 8 months ago (2014-04-16 16:27:51 UTC) #2

Igor Sheludko

6 years, 8 months ago (2014-04-16 18:28:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20821 (presubmit successful).