Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: extensions/browser/api/device_permissions_prompt.h

Issue 2390823005: Update device permissions dialog ui for Chrome apps and extensions (Closed)
Patch Set: address more comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/api/device_permissions_prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/device_permissions_prompt.h
diff --git a/extensions/browser/api/device_permissions_prompt.h b/extensions/browser/api/device_permissions_prompt.h
index cbe5e8ff6e6ba4865ec1f52b667e8255f419e6a3..13f92eb5130d821d54dce2e1caa1c4176ef4c982 100644
--- a/extensions/browser/api/device_permissions_prompt.h
+++ b/extensions/browser/api/device_permissions_prompt.h
@@ -68,7 +68,10 @@ class DevicePermissionsPrompt {
// implementation should register an observer.
class Observer {
public:
- virtual void OnDevicesChanged() = 0;
+ virtual void OnDeviceAdded(size_t index,
+ const base::string16& device_name) = 0;
+ virtual void OnDeviceRemoved(size_t index,
+ const base::string16& device_name) = 0;
protected:
virtual ~Observer();
@@ -81,8 +84,6 @@ class DevicePermissionsPrompt {
// Only one observer may be registered at a time.
virtual void SetObserver(Observer* observer);
- virtual base::string16 GetHeading() const = 0;
- base::string16 GetPromptMessage() const;
size_t GetDeviceCount() const { return devices_.size(); }
base::string16 GetDeviceName(size_t index) const;
base::string16 GetDeviceSerialNumber(size_t index) const;
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/api/device_permissions_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698