Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: extensions/browser/api/device_permissions_prompt_unittest.cc

Issue 2390823005: Update device permissions dialog ui for Chrome apps and extensions (Closed)
Patch Set: address more comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/device_permissions_prompt.cc ('k') | extensions/browser/api/hid/hid_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/device_permissions_prompt_unittest.cc
diff --git a/extensions/browser/api/device_permissions_prompt_unittest.cc b/extensions/browser/api/device_permissions_prompt_unittest.cc
deleted file mode 100644
index ba6a07eaae40d14c41950795a9dcf448bff98cad..0000000000000000000000000000000000000000
--- a/extensions/browser/api/device_permissions_prompt_unittest.cc
+++ /dev/null
@@ -1,79 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/memory/ref_counted.h"
-#include "base/strings/utf_string_conversions.h"
-#include "extensions/browser/api/device_permissions_prompt.h"
-#include "extensions/common/extension.h"
-#include "extensions/common/extension_builder.h"
-#include "extensions/common/value_builder.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace extensions {
-
-namespace {
-
-class DevicePermissionsPromptTest : public testing::Test {};
-
-TEST_F(DevicePermissionsPromptTest, HidPromptMessages) {
- scoped_refptr<Extension> extension =
- ExtensionBuilder()
- .SetManifest(DictionaryBuilder()
- .Set("name", "Test Application")
- .Set("manifest_version", 2)
- .Set("version", "1.0")
- .Build())
- .Build();
-
- scoped_refptr<DevicePermissionsPrompt::Prompt> prompt =
- DevicePermissionsPrompt::CreateHidPromptForTest(extension.get(), false);
- EXPECT_EQ(base::ASCIIToUTF16("Select a HID device"), prompt->GetHeading());
- EXPECT_EQ(
- base::ASCIIToUTF16(
- "The application \"Test Application\" is requesting access to one of "
- "your devices."),
- prompt->GetPromptMessage());
-
- prompt =
- DevicePermissionsPrompt::CreateHidPromptForTest(extension.get(), true);
- EXPECT_EQ(base::ASCIIToUTF16("Select HID devices"), prompt->GetHeading());
- EXPECT_EQ(
- base::ASCIIToUTF16(
- "The application \"Test Application\" is requesting access to one or "
- "more of your devices."),
- prompt->GetPromptMessage());
-}
-
-TEST_F(DevicePermissionsPromptTest, UsbPromptMessages) {
- scoped_refptr<Extension> extension =
- ExtensionBuilder()
- .SetManifest(DictionaryBuilder()
- .Set("name", "Test Application")
- .Set("manifest_version", 2)
- .Set("version", "1.0")
- .Build())
- .Build();
-
- scoped_refptr<DevicePermissionsPrompt::Prompt> prompt =
- DevicePermissionsPrompt::CreateUsbPromptForTest(extension.get(), false);
- EXPECT_EQ(base::ASCIIToUTF16("Select a USB device"), prompt->GetHeading());
- EXPECT_EQ(
- base::ASCIIToUTF16(
- "The application \"Test Application\" is requesting access to one of "
- "your devices."),
- prompt->GetPromptMessage());
-
- prompt =
- DevicePermissionsPrompt::CreateUsbPromptForTest(extension.get(), true);
- EXPECT_EQ(base::ASCIIToUTF16("Select USB devices"), prompt->GetHeading());
- EXPECT_EQ(
- base::ASCIIToUTF16(
- "The application \"Test Application\" is requesting access to one or "
- "more of your devices."),
- prompt->GetPromptMessage());
-}
-
-} // namespace
-
-} // namespace extensions
« no previous file with comments | « extensions/browser/api/device_permissions_prompt.cc ('k') | extensions/browser/api/hid/hid_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698