Update device permissions dialog ui for Chrome apps and extensions

chrome/browser/ui/views/chooser_content_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chooser_content_view.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/numerics/safe_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 266 matching lines @@
   return button == ui::DIALOG_BUTTON_OK
              ? chooser_controller_->GetOkButtonLabel()
              : l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_CANCEL_BUTTON_TEXT);
 }
 
 bool ChooserContentView::IsDialogButtonEnabled(ui::DialogButton button) const {
   return button != ui::DIALOG_BUTTON_OK ||
          !table_view_->selection_model().empty();
 }
 
+views::StyledLabel* ChooserContentView::footnote_link() {
+  if (chooser_controller_->ShouldShowFootnoteView())

[sky, 2016/11/28 23:13:21]

Can ShouldShowFootnoteView change value? Assuming it can't did you consider only
creating footnote_link_ when necessary? It would mean more null checks, but that
way it forces people to think about what they use the footnote_link_ for as it
might be null.

[juncai, 2016/11/29 18:10:08]

Done.

+    return footnote_link_.get();
+  return nullptr;
+}
+
 void ChooserContentView::Accept() {
   std::vector<size_t> indices(
       table_view_->selection_model().selected_indices().begin(),
       table_view_->selection_model().selected_indices().end());
   chooser_controller_->Select(indices);
 }
 
 void ChooserContentView::Cancel() {
   chooser_controller_->Cancel();
 }
@@ skipping 11 matching lines @@
   }
 }
 
 void ChooserContentView::SetGetHelpAndReScanLink() {
   footnote_link_->SetText(help_and_re_scan_text_);
   footnote_link_->AddStyleRange(
       help_text_range_, views::StyledLabel::RangeStyleInfo::CreateForLink());
   footnote_link_->AddStyleRange(
       re_scan_text_range_, views::StyledLabel::RangeStyleInfo::CreateForLink());
 }