Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2390813002: Revert of Move synthetic gesture input to be aligned with BeginFrame. (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move synthetic gesture input to be aligned with BeginFrame. (patchset #2 id:20001 of https://codereview.chromium.org/2372873003/ ) Reason for revert: Appears RenderWidgetHostViewChildFrame ends up calling a virtual during the constructor and this isn't getting called. This is an existing bug. But the change in this CL reveals this bug so reverting this change for now. Original issue's description: > Move synthetic gesture input to be aligned with BeginFrame. > > The timing of synthetic events seems almost random. It is best to align > it with something that doesn't fluctuate. Android already rAF aligns its > synthetic input so do this for aura and mac as well. > > BUG=646369 > > Committed: https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539 > Cr-Commit-Position: refs/heads/master@{#421528} TBR=sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646369 Committed: https://crrev.com/dfb4211ebbd9934c01cca376edf70fe44daa381f Cr-Commit-Position: refs/heads/master@{#422509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -65 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +0 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +5 lines, -26 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dtapuska
Created Revert of Move synthetic gesture input to be aligned with BeginFrame.
4 years, 2 months ago (2016-10-03 19:39:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390813002/1
4 years, 2 months ago (2016-10-03 19:40:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 20:22:07 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:23:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfb4211ebbd9934c01cca376edf70fe44daa381f
Cr-Commit-Position: refs/heads/master@{#422509}

Powered by Google App Engine
This is Rietveld 408576698