Remove stale commented-out DCHECK

Remove stale commented-out DCHECK

This DCHECK was commented out in Apr 2014
(https://chromium.googlesource.com/chromium/src/+/8a343ad96e4ca48eb665a77a6db8beb4357fe67c)
because it was causing Chrome OS test failures. Since this assertion has been
ignored for 2.5 years and the logic in this part of the code has since changed,
it is not clear that this assertion would be useful if it were ever re-enabled.

BUG=365507
Committed: https://crrev.com/749309fd4a6ca3ee22c9df4901037bac75ce35cd
Cr-Commit-Position: refs/heads/master@{#422733}

[suzyh_UTC10 (ex-contributor), 2016-10-04 02:06:50]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-10-04 02:50:10]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[alancutter (OOO until 2018), 2016-10-04 02:50:11]

If you're going to remove this check I think the code around the
animationStyleRecalc variable should also be cleaned up.

I can't make sense of what this check is trying to verify. If it's an animation
style recalc then active transitions that are unlisted in transition-property
must be finished? That doesn't make sense to me, shouldn't active transitions
always be listed during animation style recalcs?

Perhaps +dstockwell can shed light on the intention here.

[dstockwell, 2016-10-04 03:02:08]

On 2016/10/04 at 02:50:11, alancutter wrote:
> If you're going to remove this check I think the code around the
animationStyleRecalc variable should also be cleaned up.
> 
> I can't make sense of what this check is trying to verify. If it's an
animation style recalc then active transitions that are unlisted in
transition-property must be finished? That doesn't make sense to me, shouldn't
active transitions always be listed during animation style recalcs?
> 
> Perhaps +dstockwell can shed light on the intention here.

Not sure, removing it seems reasonable.

[suzyh_UTC10 (ex-contributor), 2016-10-04 04:00:12]

On 2016/10/04 at 03:02:08, dstockwell wrote:
> On 2016/10/04 at 02:50:11, alancutter wrote:
> > If you're going to remove this check I think the code around the
animationStyleRecalc variable should also be cleaned up.
> > 
> > I can't make sense of what this check is trying to verify. If it's an
animation style recalc then active transitions that are unlisted in
transition-property must be finished? That doesn't make sense to me, shouldn't
active transitions always be listed during animation style recalcs?
> > 
> > Perhaps +dstockwell can shed light on the intention here.
> 
> Not sure, removing it seems reasonable.

Done.

[alancutter (OOO until 2018), 2016-10-04 05:21:48]

lgtm

[suzyh_UTC10 (ex-contributor), 2016-10-04 05:28:29]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:28:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 05:30:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:30:27]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[suzyh_UTC10 (ex-contributor), 2016-10-04 05:40:43]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-10-04 05:40:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2390803004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-04 05:41:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 08:15:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 08:17:28]

Description was changed from

==========
Remove stale commented-out DCHECK

This DCHECK was commented out in Apr 2014
(https://chromium.googlesource.com/chromium/src/+/8a343ad96e4ca48eb665a77a6db8...)
because it was causing Chrome OS test failures. Since this assertion has been
ignored for 2.5 years and the logic in this part of the code has since changed,
it is not clear that this assertion would be useful if it were ever re-enabled.

BUG=365507
==========

to

==========
Remove stale commented-out DCHECK

This DCHECK was commented out in Apr 2014
(https://chromium.googlesource.com/chromium/src/+/8a343ad96e4ca48eb665a77a6db8...)
because it was causing Chrome OS test failures. Since this assertion has been
ignored for 2.5 years and the logic in this part of the code has since changed,
it is not clear that this assertion would be useful if it were ever re-enabled.

BUG=365507

Committed: https://crrev.com/749309fd4a6ca3ee22c9df4901037bac75ce35cd
Cr-Commit-Position: refs/heads/master@{#422733}
==========

[commit-bot: I haz the power, 2016-10-04 08:17:29]

Patchset 3 (id:??) landed as
https://crrev.com/749309fd4a6ca3ee22c9df4901037bac75ce35cd
Cr-Commit-Position: refs/heads/master@{#422733}