net/base/net_errors.h - Issue 23908005: Handle all non-overridable SSL errors in the same place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_errors.h

Issue 23908005: Handle all non-overridable SSL errors in the same place (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Accidentally removed whitespace, added back in Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/net_errors.h

diff --git a/net/base/net_errors.h b/net/base/net_errors.h

index 21749d8b76b3062c03349c18bfa7239bc1901c5d..34e355e1104c72e5bbc6c20f0e741c6f99f91b9c 100644

--- a/net/base/net_errors.h

+++ b/net/base/net_errors.h

@@ -36,7 +36,9 @@ NET_EXPORT const char* ErrorToString(int error);

inline bool IsCertificateError(int error) {

// Certificate errors are negative integers from net::ERR_CERT_BEGIN

// (inclusive) to net::ERR_CERT_END (exclusive) in *decreasing* order.

- return error <= ERR_CERT_BEGIN && error > ERR_CERT_END;

+ return (error <= ERR_CERT_BEGIN && error > ERR_CERT_END) ||

+ (error == ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY) ||

+ (error == ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN);

}

// Map system error code to Error.