Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: net/base/net_errors.h

Issue 23908005: Handle all non-overridable SSL errors in the same place (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Verified that nothing broke despite time passing Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/ssl/ssl_policy.cc ('k') | net/cert/cert_status_flags.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_BASE_NET_ERRORS_H__ 5 #ifndef NET_BASE_NET_ERRORS_H__
6 #define NET_BASE_NET_ERRORS_H__ 6 #define NET_BASE_NET_ERRORS_H__
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 18 matching lines...) Expand all
29 ERR_CERT_BEGIN = ERR_CERT_COMMON_NAME_INVALID, 29 ERR_CERT_BEGIN = ERR_CERT_COMMON_NAME_INVALID,
30 }; 30 };
31 31
32 // Returns a textual representation of the error code for logging purposes. 32 // Returns a textual representation of the error code for logging purposes.
33 NET_EXPORT const char* ErrorToString(int error); 33 NET_EXPORT const char* ErrorToString(int error);
34 34
35 // Returns true if |error| is a certificate error code. 35 // Returns true if |error| is a certificate error code.
36 inline bool IsCertificateError(int error) { 36 inline bool IsCertificateError(int error) {
37 // Certificate errors are negative integers from net::ERR_CERT_BEGIN 37 // Certificate errors are negative integers from net::ERR_CERT_BEGIN
38 // (inclusive) to net::ERR_CERT_END (exclusive) in *decreasing* order. 38 // (inclusive) to net::ERR_CERT_END (exclusive) in *decreasing* order.
39 return error <= ERR_CERT_BEGIN && error > ERR_CERT_END; 39 return (error <= ERR_CERT_BEGIN && error > ERR_CERT_END) ||
40 (error == ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY) ||
41 (error == ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN);
40 } 42 }
41 43
42 // Map system error code to Error. 44 // Map system error code to Error.
43 NET_EXPORT Error MapSystemError(int os_error); 45 NET_EXPORT Error MapSystemError(int os_error);
44 46
45 // Returns a list of all the possible net error codes (not counting OK). This 47 // Returns a list of all the possible net error codes (not counting OK). This
46 // is intended for use with UMA histograms that are reporting the result of 48 // is intended for use with UMA histograms that are reporting the result of
47 // an action that is represented as a net error code. 49 // an action that is represented as a net error code.
48 // 50 //
49 // Note that the error codes are all positive (since histograms expect positive 51 // Note that the error codes are all positive (since histograms expect positive
50 // sample values). Also note that a guard bucket is created after any valid 52 // sample values). Also note that a guard bucket is created after any valid
51 // error code that is not followed immediately by a valid error code. 53 // error code that is not followed immediately by a valid error code.
52 NET_EXPORT std::vector<int> GetAllErrorCodesForUma(); 54 NET_EXPORT std::vector<int> GetAllErrorCodesForUma();
53 55
54 // A convenient function to translate platform file error to net error code. 56 // A convenient function to translate platform file error to net error code.
55 NET_EXPORT Error PlatformFileErrorToNetError( 57 NET_EXPORT Error PlatformFileErrorToNetError(
56 base::PlatformFileError file_error); 58 base::PlatformFileError file_error);
57 59
58 } // namespace net 60 } // namespace net
59 61
60 #endif // NET_BASE_NET_ERRORS_H__ 62 #endif // NET_BASE_NET_ERRORS_H__
OLDNEW
« no previous file with comments | « content/browser/ssl/ssl_policy.cc ('k') | net/cert/cert_status_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698