Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Side by Side Diff: chrome/browser/ssl/ssl_error_info.cc

Issue 23908005: Handle all non-overridable SSL errors in the same place (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Verified that nothing broke despite time passing Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ssl/ssl_error_info.h ('k') | content/browser/ssl/ssl_policy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ssl/ssl_error_info.h" 5 #include "chrome/browser/ssl/ssl_error_info.h"
6 6
7 #include "base/i18n/time_formatting.h" 7 #include "base/i18n/time_formatting.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "content/public/browser/cert_store.h" 9 #include "content/public/browser/cert_store.h"
10 #include "grit/chromium_strings.h" 10 #include "grit/chromium_strings.h"
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 details = l10n_util::GetStringFUTF16( 191 details = l10n_util::GetStringFUTF16(
192 IDS_CERT_ERROR_WEAK_KEY_DETAILS, UTF8ToUTF16(request_url.host())); 192 IDS_CERT_ERROR_WEAK_KEY_DETAILS, UTF8ToUTF16(request_url.host()));
193 short_description = l10n_util::GetStringUTF16( 193 short_description = l10n_util::GetStringUTF16(
194 IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION); 194 IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION);
195 extra_info.push_back( 195 extra_info.push_back(
196 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1)); 196 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
197 extra_info.push_back( 197 extra_info.push_back(
198 l10n_util::GetStringUTF16( 198 l10n_util::GetStringUTF16(
199 IDS_CERT_ERROR_WEAK_KEY_EXTRA_INFO_2)); 199 IDS_CERT_ERROR_WEAK_KEY_EXTRA_INFO_2));
200 break; 200 break;
201 case CERT_WEAK_KEY_DH:
202 title = l10n_util::GetStringUTF16(
203 IDS_ERRORPAGES_HEADING_WEAK_SERVER_EPHEMERAL_DH_KEY);
204 details = l10n_util::GetStringFUTF16(
205 IDS_CERT_ERROR_WEAK_KEY_DETAILS, UTF8ToUTF16(request_url.host()));
206 short_description = l10n_util::GetStringUTF16(
207 IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION);
208 extra_info.push_back(
209 l10n_util::GetStringUTF16(
210 IDS_ERRORPAGES_SUMMARY_WEAK_SERVER_EPHEMERAL_DH_KEY));
211 case CERT_PINNED_KEY_MISSING:
212 title = l10n_util::GetStringUTF16(
213 IDS_ERRORPAGES_HEADING_PINNING_FAILURE);
214 details = l10n_util::GetStringUTF16(
215 IDS_ERRORPAGES_SUMMARY_PINNING_FAILURE);
216 short_description = l10n_util::GetStringUTF16(
217 IDS_ERRORPAGES_DETAILS_PINNING_FAILURE);
201 case UNKNOWN: 218 case UNKNOWN:
202 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_TITLE); 219 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_TITLE);
203 details = l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_DETAILS); 220 details = l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_DETAILS);
204 short_description = 221 short_description =
205 l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_DESCRIPTION); 222 l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_DESCRIPTION);
206 break; 223 break;
207 default: 224 default:
208 NOTREACHED(); 225 NOTREACHED();
209 } 226 }
210 return SSLErrorInfo(title, details, short_description, extra_info); 227 return SSLErrorInfo(title, details, short_description, extra_info);
(...skipping 18 matching lines...) Expand all
229 case net::ERR_CERT_UNABLE_TO_CHECK_REVOCATION: 246 case net::ERR_CERT_UNABLE_TO_CHECK_REVOCATION:
230 return CERT_UNABLE_TO_CHECK_REVOCATION; 247 return CERT_UNABLE_TO_CHECK_REVOCATION;
231 case net::ERR_CERT_REVOKED: 248 case net::ERR_CERT_REVOKED:
232 return CERT_REVOKED; 249 return CERT_REVOKED;
233 case net::ERR_CERT_INVALID: 250 case net::ERR_CERT_INVALID:
234 return CERT_INVALID; 251 return CERT_INVALID;
235 case net::ERR_CERT_WEAK_SIGNATURE_ALGORITHM: 252 case net::ERR_CERT_WEAK_SIGNATURE_ALGORITHM:
236 return CERT_WEAK_SIGNATURE_ALGORITHM; 253 return CERT_WEAK_SIGNATURE_ALGORITHM;
237 case net::ERR_CERT_WEAK_KEY: 254 case net::ERR_CERT_WEAK_KEY:
238 return CERT_WEAK_KEY; 255 return CERT_WEAK_KEY;
256 case net::ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY:
257 return CERT_WEAK_KEY_DH;
258 case net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN:
259 return CERT_PINNED_KEY_MISSING;
239 default: 260 default:
240 NOTREACHED(); 261 NOTREACHED();
241 return UNKNOWN; 262 return UNKNOWN;
242 } 263 }
243 } 264 }
244 265
245 // static 266 // static
246 int SSLErrorInfo::GetErrorsForCertStatus(int cert_id, 267 int SSLErrorInfo::GetErrorsForCertStatus(int cert_id,
247 net::CertStatus cert_status, 268 net::CertStatus cert_status,
248 const GURL& url, 269 const GURL& url,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 cert_id, &cert); 303 cert_id, &cert);
283 DCHECK(r); 304 DCHECK(r);
284 } 305 }
285 if (errors) 306 if (errors)
286 errors->push_back( 307 errors->push_back(
287 SSLErrorInfo::CreateError(kErrorTypes[i], cert.get(), url)); 308 SSLErrorInfo::CreateError(kErrorTypes[i], cert.get(), url));
288 } 309 }
289 } 310 }
290 return count; 311 return count;
291 } 312 }
OLDNEW
« no previous file with comments | « chrome/browser/ssl/ssl_error_info.h ('k') | content/browser/ssl/ssl_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698