Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h

Issue 2390783006: [DevTools] Accessibility: Show siblings and children of selected node (Closed)
Patch Set: Rebase tests again and be consistent about backendDOMNodeId Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
index b0eb77ce18e23eae8914db0c6aaf3e34fb0ae9cd..49f1babfddf467db1c4c142fa503de37bbec5305 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
@@ -12,9 +12,13 @@
namespace blink {
class AXObject;
+class AXObjectCacheImpl;
class InspectorDOMAgent;
class Page;
+using protocol::Accessibility::AXNode;
+using protocol::Accessibility::AXNodeId;
+
class MODULES_EXPORT InspectorAccessibilityAgent
: public InspectorBaseAgent<protocol::Accessibility::Metainfo> {
WTF_MAKE_NONCOPYABLE(InspectorAccessibilityAgent);
@@ -26,22 +30,68 @@ class MODULES_EXPORT InspectorAccessibilityAgent
DECLARE_VIRTUAL_TRACE();
// Protocol methods.
- Response getAXNodeChain(
+ Response getPartialAXTree(
int domNodeId,
- bool fetchAncestors,
+ Maybe<bool> fetchRelatives,
std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>*)
override;
private:
+ std::unique_ptr<AXNode> buildObjectForIgnoredNode(
+ Node* domNode,
+ AXObject*,
+ bool fetchRelatives,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void populateDOMNodeRelatives(Node& inspectedDOMNode,
+ AXNode&,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void findDOMNodeChildren(std::unique_ptr<protocol::Array<AXNodeId>>& childIds,
+ Node& parentNode,
+ Node& inspectedDOMNode,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ std::unique_ptr<AXNode> buildProtocolAXObject(
+ AXObject&,
+ AXObject* inspectedAXObject,
+ bool fetchRelatives,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void fillCoreProperties(AXObject&,
+ AXObject* inspectedAXObject,
+ bool fetchRelatives,
+ AXNode&,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addAncestors(AXObject& firstAncestor,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void populateRelatives(AXObject&,
+ AXObject* inspectedAXObject,
+ AXNode&,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addSiblingsOfIgnored(
+ std::unique_ptr<protocol::Array<AXNodeId>>& childIds,
+ AXObject& parentAXObject,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addChild(std::unique_ptr<protocol::Array<AXNodeId>>& childIds,
+ AXObject& childAXObject,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addChildren(AXObject&,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<AXNodeId>>& childIds,
+ std::unique_ptr<protocol::Array<AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+
Member<Page> m_page;
Member<InspectorDOMAgent> m_domAgent;
-
- std::unique_ptr<protocol::Accessibility::AXNode> buildObjectForIgnoredNode(
- Node* domNode,
- AXObject*) const;
- std::unique_ptr<protocol::Accessibility::AXNode> buildProtocolAXObject(
- AXObject&) const;
- void fillCoreProperties(AXObject&, protocol::Accessibility::AXNode&) const;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698