[DevTools] Accessibility: Show siblings and children of selected node

third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
index 5cebc51c459590b1936b5f5d3917e20762e34b15..a772e85c0968027a24777bd5ad79b4efdf11da7d 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
@@ -33,23 +33,24 @@ WebInspector.AccessibilitySidebarView.prototype = {
     },
 
     /**
-     * @param {?Array<!WebInspector.AccessibilityNode>} nodes
+     * @param {?WebInspector.AccessibilityNode} axNode
      */
-    accessibilityNodeCallback: function(nodes)
+    accessibilityNodeCallback: function(axNode)
     {
-        if (!nodes)
+        if (!axNode)
             return;
 
-        var currentAXNode = nodes[0];
-        if (currentAXNode.ignored)
+        this._axNode = axNode;
+
+        if (axNode.ignored())
             this._sidebarPaneStack.removeView(this._ariaSubPane);
         else
             this._sidebarPaneStack.showView(this._ariaSubPane, this._axNodeSubPane);
 
         if (this._axNodeSubPane)
-            this._axNodeSubPane.setAXNode(currentAXNode);
+            this._axNodeSubPane.setAXNode(axNode);
         if (this._treeSubPane)
-            this._treeSubPane.setAXNodeAndAncestors(nodes);
+            this._treeSubPane.setAXNode(axNode);
     },
 
     /**
@@ -63,8 +64,13 @@ WebInspector.AccessibilitySidebarView.prototype = {
         this._treeSubPane.setNode(node);
         this._axNodeSubPane.setNode(node);
         this._ariaSubPane.setNode(node);
-        return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNodeChain(node)
-            .then((nodes) => { this.accessibilityNodeCallback(nodes); });
+        if (!node)
+            return Promise.resolve();
+        var accessibilityModel = WebInspector.AccessibilityModel.fromTarget(node.target());
+        return accessibilityModel.setDOMNode(node)
+            .then(accessibilityModel.resolveAllDOMNodes.bind(accessibilityModel))

[dgozman, 2016/10/31 21:36:30]

What's the point of resolving all the nodes right away? Should we push nodes
from backend before sending ids instead, so that there is no need to resolve?

[aboxhall, 2016/10/31 22:45:15]

You mean send a front-end ID? I think I tried that when I was originally
creating the protocol and got some push-back. In general I would vastly prefer
that if possible!

The reason we need to resolve them all is so we can match up the inspected node
with its corresponding AX node.

+            .then(accessibilityModel.getInspectedAXNode.bind(accessibilityModel))
+            .then((axNode) => { this.accessibilityNodeCallback(axNode); });
     },
 
     /**