Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Issue 2390783006: [DevTools] Accessibility: Show siblings and children of selected node (Closed)
Patch Set: Handle non-rendered nodes which are not top-level Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
index 309f4876cd16cf85a8112fefbda4a0f35bc9bbf5..ed2862d1cdee28c9d15d9d37197069170d271638 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
@@ -33,23 +33,24 @@ WebInspector.AccessibilitySidebarView.prototype = {
},
/**
- * @param {?Array<!WebInspector.AccessibilityNode>} nodes
+ * @param {?WebInspector.AccessibilityNode} axNode
*/
- accessibilityNodeCallback: function(nodes)
+ accessibilityNodeCallback: function(axNode)
{
- if (!nodes)
+ if (!axNode)
return;
- var currentAXNode = nodes[0];
- if (currentAXNode.ignored)
+ this._axNode = axNode;
+
+ if (axNode.ignored())
this._sidebarPaneStack.removeView(this._ariaSubPane);
else
this._sidebarPaneStack.showView(this._ariaSubPane, this._axNodeSubPane);
if (this._axNodeSubPane)
- this._axNodeSubPane.setAXNode(currentAXNode);
+ this._axNodeSubPane.setAXNode(axNode);
if (this._treeSubPane)
- this._treeSubPane.setAXNodeAndAncestors(nodes);
+ this._treeSubPane.setAXNode(axNode);
},
/**
@@ -63,8 +64,13 @@ WebInspector.AccessibilitySidebarView.prototype = {
this._treeSubPane.setNode(node);
this._axNodeSubPane.setNode(node);
this._ariaSubPane.setNode(node);
- return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNodeChain(node)
- .then((nodes) => { this.accessibilityNodeCallback(nodes); });
+ if (!node)
+ return Promise.resolve();
+ var accessibilityModel = WebInspector.AccessibilityModel.fromTarget(node.target());
+ return accessibilityModel.setDOMNode(node)
+ .then(accessibilityModel.resolveAllDOMNodes.bind(accessibilityModel))
+ .then(accessibilityModel.getInspectedAXNode.bind(accessibilityModel))
+ .then((axNode) => { this.accessibilityNodeCallback(axNode); });
},
/**

Powered by Google App Engine
This is Rietveld 408576698