Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp

Issue 2390783006: [DevTools] Accessibility: Show siblings and children of selected node (Closed)
Patch Set: Ready for a first look Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
index deefc72632b8de523c436728caea4cd122f8f738..fa3c210b9c56d3a6e9472c3e77ff94e972ee0a7f 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
@@ -63,7 +63,7 @@ std::unique_ptr<AXProperty> createProperty(IgnoredReason reason) {
if (reason.relatedObject)
return createProperty(
ignoredReasonName(reason.reason),
- createRelatedNodeListValue(reason.relatedObject, nullptr,
+ createRelatedNodeListValue(*(reason.relatedObject), nullptr,
AXValueTypeEnum::Idref));
return createProperty(ignoredReasonName(reason.reason),
createBooleanValue(true));
@@ -97,9 +97,9 @@ std::unique_ptr<AXValue> createBooleanValue(bool value, const String& type) {
.build();
}
-std::unique_ptr<AXRelatedNode> relatedNodeForAXObject(const AXObject* axObject,
+std::unique_ptr<AXRelatedNode> relatedNodeForAXObject(const AXObject& axObject,
String* name = nullptr) {
- Node* node = axObject->getNode();
+ Node* node = axObject.getNode();
if (!node)
return nullptr;
int backendNodeId = DOMNodeIds::idForNode(node);
@@ -120,7 +120,7 @@ std::unique_ptr<AXRelatedNode> relatedNodeForAXObject(const AXObject* axObject,
return relatedNode;
}
-std::unique_ptr<AXValue> createRelatedNodeListValue(const AXObject* axObject,
+std::unique_ptr<AXValue> createRelatedNodeListValue(const AXObject& axObject,
String* name,
const String& valueType) {
std::unique_ptr<protocol::Array<AXRelatedNode>> relatedNodes =
@@ -139,7 +139,7 @@ std::unique_ptr<AXValue> createRelatedNodeListValue(
protocol::Array<AXRelatedNode>::create();
for (unsigned i = 0; i < relatedObjects.size(); i++) {
std::unique_ptr<AXRelatedNode> frontendRelatedNode = relatedNodeForAXObject(
- relatedObjects[i]->object, &(relatedObjects[i]->text));
+ *(relatedObjects[i]->object), &(relatedObjects[i]->text));
if (frontendRelatedNode)
frontendRelatedNodes->addItem(std::move(frontendRelatedNode));
}
@@ -156,7 +156,7 @@ std::unique_ptr<AXValue> createRelatedNodeListValue(
protocol::Array<AXRelatedNode>::create();
for (unsigned i = 0; i < axObjects.size(); i++) {
std::unique_ptr<AXRelatedNode> relatedNode =
- relatedNodeForAXObject(axObjects[i].get());
+ relatedNodeForAXObject(*(axObjects[i].get()));
if (relatedNode)
relatedNodes->addItem(std::move(relatedNode));
}

Powered by Google App Engine
This is Rietveld 408576698