third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2390783006: [DevTools] Accessibility: Show siblings and children of selected node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2390783006: [DevTools] Accessibility: Show siblings and children of selected node (Closed)

Patch Set: Ready for a first look Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h » ('j') | third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index dfff8fc9842bb39f3eb8c8d20a5e0bf0ceb06eb2..8ef1fd57e2ed92cea0defee76dc340258bd4f807 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -351,11 +351,13 @@ AXObject* AXObjectCacheImpl::getOrCreate(Node* node) {

// If the node has a layout object, prefer using that as the primary key for

// the AXObject, with the exception of an HTMLAreaElement, which is created

// based on its node.

- if (node->layoutObject() && !isHTMLAreaElement(node))

+ if (node->layoutObject() && !isHTMLAreaElement(node)) {

return getOrCreate(node->layoutObject());

+ }

- if (!node->parentElement())

+ if (!node->parentElement()) {

return 0;

+ }

if (isHTMLHeadElement(node))

return 0;