[DevTools] Accessibility: Show siblings and children of selected node

third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef InspectorAccessibilityAgent_h
 #define InspectorAccessibilityAgent_h
 
 #include "core/inspector/InspectorBaseAgent.h"
 #include "core/inspector/protocol/Accessibility.h"
 #include "modules/ModulesExport.h"
@@ skipping 10 matching lines @@
     : public InspectorBaseAgent<protocol::Accessibility::Metainfo> {
   WTF_MAKE_NONCOPYABLE(InspectorAccessibilityAgent);
 
  public:
   InspectorAccessibilityAgent(Page*, InspectorDOMAgent*);
 
   // Base agent methods.
   DECLARE_VIRTUAL_TRACE();
 
   // Protocol methods.
-  void getAXNodeChain(
+  void getPartialAXTree(
       ErrorString*,
       int domNodeId,
-      bool fetchAncestors,
+      const Maybe<bool>& fetchRelatives,
       std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>*)
       override;
 
  private:
   Member<Page> m_page;
   Member<InspectorDOMAgent> m_domAgent;
 
   std::unique_ptr<protocol::Accessibility::AXNode> buildObjectForIgnoredNode(
       Node* domNode,
-      AXObject*) const;
+      AXObject*,
+      bool fetchRelatives,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,

[dgozman, 2016/11/03 22:07:29]

I'd suggest to do
using protocol::Accessibility::AXNode;
using protocol::Accessibility::AXNodeId;

[aboxhall, 2016/11/04 22:31:17]

Isn't this somewhat frowned upon?
https://google.github.io/styleguide/cppguide.html#Aliases

[dgozman, 2016/11/04 23:22:44]

I think this qualifies for the last bullet there: "However, local convenience
aliases are fine in function definitions, private sections of classes,
explicitly marked internal namespaces, and in .cc files".

+      AXObjectCacheImpl&) const;
+  void populateDOMNodeRelatives(
+      Node& inspectedDOMNode,
+      protocol::Accessibility::AXNode&,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
+  void findDOMNodeChildren(
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+          childIds,
+      Node& parentNode,
+      Node& inspectedDOMNode,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
   std::unique_ptr<protocol::Accessibility::AXNode> buildProtocolAXObject(
-      AXObject&) const;
-  void fillCoreProperties(AXObject&, protocol::Accessibility::AXNode&) const;
+      AXObject&,
+      AXObject* inspectedAXObject,
+      bool fetchRelatives,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
+  void fillCoreProperties(
+      AXObject&,
+      AXObject* inspectedAXObject,
+      bool fetchRelatives,
+      protocol::Accessibility::AXNode&,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
+  void addAncestors(
+      AXObject& firstAncestor,
+      AXObject* inspectedAXObject,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
+  void populateRelatives(
+      AXObject&,
+      AXObject* inspectedAXObject,
+      protocol::Accessibility::AXNode&,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
+  void addSiblingsOfIgnored(
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+          childIds,
+      AXObject& parentAXObject,
+      AXObject* inspectedAXObject,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
+  void addChild(
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+          childIds,
+      AXObject& childAXObject,
+      AXObject* inspectedAXObject,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
+  void addChildren(
+      AXObject&,
+      AXObject* inspectedAXObject,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+          childIds,
+      std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+      AXObjectCacheImpl&) const;
 };
 
 }  // namespace blink
 
 #endif  // InspectorAccessibilityAgent_h