[DevTools] Accessibility: Show siblings and children of selected node

third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 WebInspector.AccessibilitySidebarView = class extends WebInspector.ThrottledWidget {
   constructor() {
     super();
     this._node = null;
@@ skipping 11 matching lines @@
   }
 
   /**
    * @return {?WebInspector.DOMNode}
    */
   node() {
     return this._node;
   }
 
   /**
-   * @param {?Array<!WebInspector.AccessibilityNode>} nodes
+   * @param {?WebInspector.AccessibilityNode} axNode
    */
-  accessibilityNodeCallback(nodes) {
-    if (!nodes)
+  accessibilityNodeCallback(axNode) {
+    if (!axNode)
       return;
 
-    var currentAXNode = nodes[0];
-    if (currentAXNode.ignored)
+    this._axNode = axNode;
+
+    if (axNode.ignored())
       this._sidebarPaneStack.removeView(this._ariaSubPane);
     else
       this._sidebarPaneStack.showView(this._ariaSubPane, this._axNodeSubPane);
 
     if (this._axNodeSubPane)
-      this._axNodeSubPane.setAXNode(currentAXNode);
+      this._axNodeSubPane.setAXNode(axNode);
     if (this._treeSubPane)
-      this._treeSubPane.setAXNodeAndAncestors(nodes);
+      this._treeSubPane.setAXNode(axNode);
   }
 
   /**
    * @override
    * @protected
    * @return {!Promise.<?>}
    */
   doUpdate() {
     var node = this.node();
     this._treeSubPane.setNode(node);
     this._axNodeSubPane.setNode(node);
     this._ariaSubPane.setNode(node);
-    return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNodeChain(node).then((nodes) => {
-      this.accessibilityNodeCallback(nodes);
-    });
+    if (!node)
+      return Promise.resolve();
+    var accessibilityModel = WebInspector.AccessibilityModel.fromTarget(node.target());
+    return accessibilityModel.setDOMNode(node)

[dgozman, 2016/11/03 22:07:29]

Instead of this, I propose to:
- call accessibilityModel.clear() to clear caches;
- call accessibilityModel.partialAXTree() to get the data;
- store resulting this._axNode (you do that in accessibilityNodeCallback);
- do not resolve all dom nodes.

This moves the management of "current node" to sidebar view, while making model
maintain caches and handling protocol calls.

[aboxhall, 2016/11/04 22:31:17]

Done, I think. Was this what you had in mind?

+        .then(accessibilityModel.resolveAllDOMNodes.bind(accessibilityModel))
+        .then(accessibilityModel.getInspectedAXNode.bind(accessibilityModel))
+        .then((axNode) => {
+          this.accessibilityNodeCallback(axNode);
+        });
   }
 
   /**
    * @override
    */
   wasShown() {
     super.wasShown();
 
     this._treeSubPane.setNode(this.node());
     this._axNodeSubPane.setNode(this.node());
@@ skipping 106 matching lines @@
   createTreeOutline() {
     var treeOutline = new TreeOutlineInShadow();
     treeOutline.registerRequiredCSS('accessibility/accessibilityNode.css');
     treeOutline.registerRequiredCSS('components/objectValue.css');
 
     treeOutline.element.classList.add('hidden');
     this.element.appendChild(treeOutline.element);
     return treeOutline;
   }
 };