Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h

Issue 2390773004: reflow comments in core/svg/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h
diff --git a/third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h b/third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h
index c5ab3e33b567830b2a331e64286ba725395ebb1b..ecccfa2719294c691fa052ec144255d6cab9fbb6 100644
--- a/third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h
+++ b/third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h
@@ -49,17 +49,22 @@ class ListItemPropertyTraits {
SVGElement* contextElement,
const QualifiedName& attributeName) {
// |newItem| is immutable, OR
- // |newItem| belongs to a SVGElement, but it does not belong to an animated list
- // (for example: "textElement.x.baseVal.appendItem(rectElement.width.baseVal)")
- // Spec: If newItem is already in a list, then a new object is created with the same values as newItem and this item is inserted into the list.
+ // |newItem| belongs to a SVGElement, but it does not belong to an animated
+ // list
pdr. 2016/10/04 21:05:30 Nit: put "e.g.," on the previous line and split up
Nico 2016/10/04 21:10:23 Done.
+ // (e.g. "textElement.x.baseVal.appendItem(rectElement.width.baseVal)")
+ // Spec: If newItem is already in a list, then a new object is created with
+ // the same values as newItem and this item is inserted into the list.
// Otherwise, newItem itself is inserted into the list.
if (newItem->isImmutable() || newItem->target()->ownerList() ||
newItem->contextElement()) {
// We have to copy the incoming |newItem|,
- // Otherwise we'll end up having two tearoffs that operate on the same SVGProperty. Consider the example below:
- // SVGRectElements SVGAnimatedLength 'width' property baseVal points to the same tear off object
- // that's inserted into SVGTextElements SVGAnimatedLengthList 'x'. textElement.x.baseVal.getItem(0).value += 150 would
- // mutate the rectElement width _and_ the textElement x list. That's obviously wrong, take care of that.
+ // Otherwise we'll end up having two tearoffs that operate on the same
+ // SVGProperty. Consider the example below: SVGRectElements
+ // SVGAnimatedLength 'width' property baseVal points to the same tear off
+ // object that's inserted into SVGTextElements SVGAnimatedLengthList 'x'.
+ // textElement.x.baseVal.getItem(0).value += 150 would mutate the
+ // rectElement width _and_ the textElement x list. That's obviously wrong,
+ // take care of that.
return newItem->target()->clone();
}

Powered by Google App Engine
This is Rietveld 408576698