Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/previews/core/previews_io_data.cc

Issue 2390773003: Adding a SQL implementation of the backing store for previews opt outs (Closed)
Patch Set: Split black list initialization and construction Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/core/previews_io_data.cc
diff --git a/components/previews/core/previews_io_data.cc b/components/previews/core/previews_io_data.cc
index 02f4b333e9af00ae7f3f0ef3364564d0876ca37b..b7661fba7c4dac1d36be723b2da8298b246727c4 100644
--- a/components/previews/core/previews_io_data.cc
+++ b/components/previews/core/previews_io_data.cc
@@ -25,29 +25,30 @@ PreviewsIOData::PreviewsIOData(
weak_factory_(this) {}
PreviewsIOData::~PreviewsIOData() {}
void PreviewsIOData::Initialize(
base::WeakPtr<PreviewsUIService> previews_ui_service,
std::unique_ptr<PreviewsOptOutStore> previews_opt_out_store) {
DCHECK(ui_task_runner_->BelongsToCurrentThread());
previews_ui_service_ = previews_ui_service;
+ previews_black_list_.reset(
+ new PreviewsBlackList(std::move(previews_opt_out_store),
+ base::MakeUnique<base::DefaultClock>()));
+
// Set up the IO thread portion of |this|.
- io_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(&PreviewsIOData::InitializeOnIOThread, base::Unretained(this),
- base::Passed(&previews_opt_out_store)));
+ io_task_runner_->PostTask(FROM_HERE,
+ base::Bind(&PreviewsIOData::InitializeOnIOThread,
+ base::Unretained(this)));
}
-void PreviewsIOData::InitializeOnIOThread(
- std::unique_ptr<PreviewsOptOutStore> previews_opt_out_store) {
+void PreviewsIOData::InitializeOnIOThread() {
DCHECK(io_task_runner_->BelongsToCurrentThread());
- previews_black_list_.reset(
- new PreviewsBlackList(std::move(previews_opt_out_store),
- base::MakeUnique<base::DefaultClock>()));
+ previews_black_list_->Initialize();
+
ui_task_runner_->PostTask(
FROM_HERE, base::Bind(&PreviewsUIService::SetIOData, previews_ui_service_,
weak_factory_.GetWeakPtr()));
}
} // namespace previews

Powered by Google App Engine
This is Rietveld 408576698