Adding a SQL implementation of the backing store for previews opt outs

chrome/common/chrome_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_constants.h"
 
 #include "build/build_config.h"
 #include "chrome/common/chrome_version.h"
 
 #define FPL FILE_PATH_LITERAL
@@ skipping 138 matching lines @@
 const base::FilePath::CharType kMediaCacheDirname[] = FPL("Media Cache");
 const base::FilePath::CharType kNetworkPersistentStateFilename[] =
     FPL("Network Persistent State");
 const base::FilePath::CharType kOfflinePageArchivesDirname[] =
     FPL("Offline Pages/archives");
 const base::FilePath::CharType kOfflinePageMetadataDirname[] =
     FPL("Offline Pages/metadata");
 const base::FilePath::CharType kOfflinePageRequestQueueDirname[] =
     FPL("Offline Pages/request_queue");
 const base::FilePath::CharType kPreferencesFilename[] = FPL("Preferences");
+const base::FilePath::CharType kPreviewsOptOutDirname[] =
+    FPL("Previews/opt_out");

[Scott Hess - ex-Googler, 2016/10/06 17:24:27]

Why a directory rather than a file?

[RyanSturm, 2016/10/06 20:05:39]

I was copying the Offline Page metadata approach, Done.

[Scott Hess - ex-Googler, 2016/10/07 00:08:45]

In that case ... I'll also question your use of kPreviewsColumns, TableInfo, and
OP_* column identifiers.  IMHO, those are not best practices.  In other areas of
the code, I find that that sort of thing somewhat obscures what is actually
going on, to no benefit.

[Yes, I have had this discussion with the Offline Page CLs.  They elected to go
forward as-is.]

[RyanSturm, 2016/10/07 20:07:05]

sgtm.

 const base::FilePath::CharType kProtectedPreferencesFilenameDeprecated[] =
     FPL("Protected Preferences");
 const base::FilePath::CharType kReadmeFilename[] = FPL("README");
 const base::FilePath::CharType kSafeBrowsingBaseFilename[] =
     FPL("Safe Browsing");
 const base::FilePath::CharType kSecurePreferencesFilename[] =
     FPL("Secure Preferences");
 const base::FilePath::CharType kServiceStateFileName[] = FPL("Service State");
 const base::FilePath::CharType kSingletonCookieFilename[] =
     FPL("SingletonCookie");
@@ skipping 43 matching lines @@
 // user can select for different file types.
 // {2676A9A2-D919-4FEE-9187-152100393AB2}
 const char kApplicationClientIDStringForAVScanning[] =
     "2676A9A2-D919-4FEE-9187-152100393AB2";
 
 const size_t kMaxMetaTagAttributeLength = 2000;
 
 }  // namespace chrome
 
 #undef FPL