Don't output earcons when constructing output from descendants

Don't output earcons when constructing output from descendants

Descendant output is fairly noisy (e.g. in Google Groups). By omitting earcons, we make it clear the output is one big utterance and also get rid of a lot of output.

For groups specifically, there are lots of editable text areas and divs marked up as focusable, so we end up getting some amount of repeated output. The earcons being played sound like an error tone because they're being played at the same time.

BUG=619279
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[David Tseng, 2016-10-03 16:34:20]

Description was changed from

==========
Don't output earcons when constructing output from descendants
==========

to

==========
Don't output earcons when constructing output from descendants
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-03 16:37:09]

Description was changed from

==========
Don't output earcons when constructing output from descendants
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Don't output earcons when constructing output from descendants

Descendant output is fairly noisy (e.g. in Google Groups). By omitting earcons,
we make it clear the output is one big utterance and also get rid of a lot of
output.

For groups specifically, there are lots of editable text areas and divs marked
up as focusable, so we end up getting some amount of repeated output. The
earcons being played sound like an error tone because they're being played at
the same time.

BUG=619279
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-03 16:37:09]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-10-03 18:27:45]

lgtm

All of this sounds good except that I think it's
really hacky to use descendantsNoEarcons for div
and not for any other role.

What about paragraph, region, rowHeader,
tableHeaderContainer? Perhaps those should
all be descendantsNoEarcons.

I think dialog and alertdialog are probably
better with earcons, what do you think?

At a minimum, I insist that paragraph and
div should have the same behavior, I think
it'd be really confusing if not.

Also, what should $nameOrDescendants do?
I suspect anything with $nameOrDescendants
should probably be without earcons too...

[David Tseng, 2016-10-03 22:06:49]

On 2016/10/03 18:27:45, dmazzoni wrote:
> lgtm
> 
> All of this sounds good except that I think it's
> really hacky to use descendantsNoEarcons for div
> and not for any other role.

div has no semantics though and this his how classic behaved (which worked
pretty well).

> 
> What about paragraph, region, rowHeader,
> tableHeaderContainer? Perhaps those should
> all be descendantsNoEarcons.
> 
> I think dialog and alertdialog are probably
> better with earcons, what do you think?
> 
> At a minimum, I insist that paragraph and
> div should have the same behavior, I think
> it'd be really confusing if not.
> 

div only appears in very special cases. Only when a div is focusable do we use
this output rule. This amounts to very ajax heavy sites that have tried hard to
implement keyboard support.

> Also, what should $nameOrDescendants do?
> I suspect anything with $nameOrDescendants
> should probably be without earcons too...