Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Issue 2390753006: Fix opt-in IME menu crash. (Closed)

Created:
4 years, 2 months ago by Azure Wei
Modified:
4 years, 2 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix opt-in IME menu crash. The crash is caused by the unsafely accessing of |title_row_| in TrayDetailsView, which is null for opt-in IME menu. Fix the crash by adding the check of |title_row_|. BUG=650287 TEST=Verified on local build. Committed: https://crrev.com/d13360c1060219cd5a2d8085fab433a8f49d414a Cr-Commit-Position: refs/heads/master@{#424049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Azure Wei
Please review this cl. Thanks!
4 years, 2 months ago (2016-10-06 08:06:23 UTC) #3
tdanderson
LGTM
4 years, 2 months ago (2016-10-06 13:57:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390753006/1
4 years, 2 months ago (2016-10-08 02:01:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 02:44:57 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 02:46:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d13360c1060219cd5a2d8085fab433a8f49d414a
Cr-Commit-Position: refs/heads/master@{#424049}

Powered by Google App Engine
This is Rietveld 408576698