Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2390733003: Make PerformanceEntry::toEntryTypeEnum case sensitive. (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
esprehn, Rick Byers
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PerformanceEntry::toEntryTypeEnum case sensitive. The performance timing spec has been clarified[1] to make getEntriesByType case sensitive. This CL updates Blink to this new requirement. [1] https://github.com/w3c/performance-timeline/issues/57 BUG=651507 Committed: https://crrev.com/9c0ff2498f7fbead1b5de0b70d22d4546aecbdfa Cr-Commit-Position: refs/heads/master@{#422650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/timing/PerformanceEntry.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dsinclair
PTAL. I didn't import the attached test because it doesn't work correctly in Blink. The ...
4 years, 2 months ago (2016-10-03 16:52:05 UTC) #4
esprehn
lgtm, but we really need to get our testing house in order. Do we need ...
4 years, 2 months ago (2016-10-04 00:16:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390733003/1
4 years, 2 months ago (2016-10-04 01:02:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 01:09:33 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 01:12:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c0ff2498f7fbead1b5de0b70d22d4546aecbdfa
Cr-Commit-Position: refs/heads/master@{#422650}

Powered by Google App Engine
This is Rietveld 408576698