Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: test/inspector/runtime/compile-script.js

Issue 2390733002: [inspector] Make InspectorTest.sendCommand* private (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/inspector/runtime/compile-script.js
diff --git a/test/inspector/runtime/compile-script.js b/test/inspector/runtime/compile-script.js
index cbbdd3277b4a7e0b07b2695ccd4ff0731b8987e2..4f1c6468e156ec8e55fecf970c6547704c7c1cfd 100644
--- a/test/inspector/runtime/compile-script.js
+++ b/test/inspector/runtime/compile-script.js
@@ -4,13 +4,13 @@
var executionContextId;
-InspectorTest.sendCommand("Debugger.enable", {}, onDebuggerEnabled);
+Protocol.Debugger.enable().then(onDebuggerEnabled);
function onDebuggerEnabled()
{
- InspectorTest.sendCommand("Runtime.enable", {});
- InspectorTest.eventHandler["Debugger.scriptParsed"] = onScriptParsed;
- InspectorTest.eventHandler["Runtime.executionContextCreated"] = onExecutionContextCreated;
+ Protocol.Runtime.enable();
+ Protocol.Debugger.onScriptParsed(onScriptParsed);
+ Protocol.Runtime.onExecutionContextCreated(onExecutionContextCreated);
}
function onScriptParsed(messageObject)
@@ -34,28 +34,17 @@ function testCompileScript(expression, persistScript, sourceURL)
{
InspectorTest.log("Compiling script: " + sourceURL);
InspectorTest.log(" persist: " + persistScript);
- var callback;
- var promise = new Promise(resolver => callback = resolver);
- InspectorTest.sendCommand("Runtime.compileScript", {
+ return Protocol.Runtime.compileScript({
expression: expression,
sourceURL: sourceURL,
persistScript: persistScript,
executionContextId: executionContextId
- }, onCompiled);
- return promise;
+ }).then(onCompiled);
function onCompiled(messageObject)
{
- var result = messageObject.result;
- if (result.exceptionDetails) {
- result.exceptionDetails.exceptionId = 0;
- result.exceptionDetails.exception.objectId = 0;
- result.exceptionDetails.scriptId = 0;
- }
- if (result.scriptId)
- result.scriptId = 0;
- InspectorTest.logObject(result, "compilation result: ");
+ InspectorTest.log("compilation result: ");
+ InspectorTest.logMessage(messageObject);
InspectorTest.log("-----");
- callback();
}
}
« no previous file with comments | « test/inspector/runtime/clear-of-command-line-api-expected.txt ('k') | test/inspector/runtime/compile-script-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698