Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: test/inspector/runtime/get-properties-preview.js

Issue 2390733002: [inspector] Make InspectorTest.sendCommand* private (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 InspectorTest.sendCommand("Runtime.evaluate", { "expression": "({p1: {a:1}, p2: {b:'foo', bb:'bar'}})" }, callbackEvaluate); 5 Protocol.Runtime.evaluate({ "expression": "({p1: {a:1}, p2: {b:'foo', bb:'bar'}} )" }).then(callbackEvaluate);
6 6
7 function callbackEvaluate(result) 7 function callbackEvaluate(result)
8 { 8 {
9 InspectorTest.sendCommand("Runtime.getProperties", { "objectId": result.result .result.objectId, "ownProperties": true }, callbackGetProperties.bind(null, fals e)); 9 Protocol.Runtime.getProperties({ "objectId": result.result.result.objectId, "o wnProperties": true }).then(callbackGetProperties.bind(null, false));
10 InspectorTest.sendCommand("Runtime.getProperties", { "objectId": result.result .result.objectId, "ownProperties": true, "generatePreview": true }, callbackGetP roperties.bind(null, true)); 10 Protocol.Runtime.getProperties({ "objectId": result.result.result.objectId, "o wnProperties": true, "generatePreview": true }).then(callbackGetProperties.bind( null, true));
11 } 11 }
12 12
13 function callbackGetProperties(completeTest, result) 13 function callbackGetProperties(completeTest, result)
14 { 14 {
15 for (var property of result.result.result) { 15 for (var property of result.result.result) {
16 if (!property.value || property.name === "__proto__") 16 if (!property.value || property.name === "__proto__")
17 continue; 17 continue;
18 if (property.value.preview) 18 if (property.value.preview)
19 InspectorTest.log(property.name + " : " + JSON.stringify(property.value.pr eview, null, 4)); 19 InspectorTest.log(property.name + " : " + JSON.stringify(property.value.pr eview, null, 4));
20 else 20 else
21 InspectorTest.log(property.name + " : " + property.value.description); 21 InspectorTest.log(property.name + " : " + property.value.description);
22 } 22 }
23 if (completeTest) 23 if (completeTest)
24 InspectorTest.completeTest(); 24 InspectorTest.completeTest();
25 } 25 }
OLDNEW
« no previous file with comments | « test/inspector/runtime/get-properties-on-proxy-expected.txt ('k') | test/inspector/runtime/property-on-console-proto.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698