Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js

Issue 2390733002: [inspector] Make InspectorTest.sendCommand* private (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 print("Tests that \"console.profileEnd()\" does not cause crash. (webkit:105759) "); 5 print("Tests that \"console.profileEnd()\" does not cause crash. (webkit:105759) ");
6 6
7 InspectorTest.evaluateInPage(` 7 InspectorTest.addScript(`
8 function collectProfiles() 8 function collectProfiles()
9 { 9 {
10 console.profile(); 10 console.profile();
11 console.profile("titled"); 11 console.profile("titled");
12 console.profileEnd(); 12 console.profileEnd();
13 console.profileEnd(); 13 console.profileEnd();
14 }`); 14 }`);
15 15
16 InspectorTest.fail = function(message) 16 InspectorTest.fail = function(message)
17 { 17 {
18 InspectorTest.log("FAIL: " + message); 18 InspectorTest.log("FAIL: " + message);
19 InspectorTest.completeTest(); 19 InspectorTest.completeTest();
20 } 20 }
21 21
22 InspectorTest.sendCommand("Profiler.enable", {}); 22 Protocol.Profiler.enable();
23 InspectorTest.sendCommand("Runtime.evaluate", { expression: "collectProfiles()"} , didCollectProfiles); 23 Protocol.Runtime.evaluate({ expression: "collectProfiles()"}).then(didCollectPro files);
24 24
25 var headers = []; 25 var headers = [];
26 InspectorTest.eventHandler["Profiler.consoleProfileFinished"] = function(message Object) 26 Protocol.Profiler.onConsoleProfileFinished(function(messageObject)
27 { 27 {
28 headers.push({ 28 headers.push({
29 title: messageObject["params"]["title"] 29 title: messageObject["params"]["title"]
30 }); 30 });
31 } 31 });
32 32
33 function didCollectProfiles(messageObject) 33 function didCollectProfiles(messageObject)
34 { 34 {
35 if (headers.length !== 2) 35 if (headers.length !== 2)
36 return InspectorTest.fail("Cannot retrive headers: " + JSON.stringify(messag eObject, null, 4)); 36 return InspectorTest.fail("Cannot retrive headers: " + JSON.stringify(messag eObject, null, 4));
37 InspectorTest.log("SUCCESS: found 2 profile headers"); 37 InspectorTest.log("SUCCESS: found 2 profile headers");
38 for (var i = 0; i < headers.length; i++) { 38 for (var i = 0; i < headers.length; i++) {
39 if (headers[i].title === "titled") { 39 if (headers[i].title === "titled") {
40 InspectorTest.log("SUCCESS: titled profile found"); 40 InspectorTest.log("SUCCESS: titled profile found");
41 InspectorTest.completeTest(); 41 InspectorTest.completeTest();
42 return; 42 return;
43 } 43 }
44 } 44 }
45 InspectorTest.fail("Cannot find titled profile"); 45 InspectorTest.fail("Cannot find titled profile");
46 } 46 }
OLDNEW
« no previous file with comments | « test/inspector/cpu-profiler/console-profile.js ('k') | test/inspector/cpu-profiler/enable-disable.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698