Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 2390723004: Revert of Disable local fallback in goma staging environment (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Disable local fallback in goma staging environment (patchset #2 id:20001 of https://codereview.chromium.org/2392853002/ ) Reason for revert: https://build.chromium.org/p/chromium.goma/builders/Chromium%20Linux%20Goma%20Staging/builds/12050/steps/compile/logs/stdio compile.py with disable_local_fallback does not stop compile when compiler_proxy fails to ping server. Original issue's description: > Disable local fallback in goma staging environment > > When rolling new server, starting goma fails sometimes due to timing issue. > > * rename goma_canary -> goma_failfast in config > > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/32eebb8c482d73dbc453dfdce62e46d4c8ee19a1 TBR=phajdan.jr@chromium.org,shinyak@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/fee67c6802805c049ddf19e436fb00ad8416032f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_goma_Chromium_Linux_Goma_Staging.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_goma_Chromium_Mac_Goma_Staging.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_goma_CrWinGomaStaging.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
tikuta
Created Revert of Disable local fallback in goma staging environment
4 years, 2 months ago (2016-10-04 10:36:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390723004/1
4 years, 2 months ago (2016-10-04 10:36:33 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 10:36:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/fee67c6802805c049ddf...

Powered by Google App Engine
This is Rietveld 408576698