Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: pkg/analysis_server/tool/instrumentation/page/stats_page.dart

Issue 2390693002: Handle session logs and add event subset selection (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/tool/instrumentation/page/stats_page.dart
diff --git a/pkg/analysis_server/tool/instrumentation/page/stats_page.dart b/pkg/analysis_server/tool/instrumentation/page/stats_page.dart
index 02ec025c07fdd95cf799733162cc7c90078b3195..42cd70453005f69bb0d5c4dedb6a3c6f7892c242 100644
--- a/pkg/analysis_server/tool/instrumentation/page/stats_page.dart
+++ b/pkg/analysis_server/tool/instrumentation/page/stats_page.dart
@@ -52,20 +52,8 @@ class StatsPage extends PageWriter {
@override
void writeBody(StringSink sink) {
writeMenu(sink);
- sink.writeln('<div id="container">');
- sink.writeln(' <div id="content">');
- sink.writeln(' <div id="leftColumn">');
- sink.writeln(' <div class="inset">');
- _writeLeftColumn(sink);
- sink.writeln(' </div>');
- sink.writeln(' </div>');
- sink.writeln(' <div id="rightColumn">');
- sink.writeln(' <div class="inset">');
- _writeRightColumn(sink);
- sink.writeln(' </div>');
- sink.writeln(' </div>');
- sink.writeln(' </div>');
- sink.writeln('</div>');
+ writeTwoColumns(
+ sink, 'leftColumn', _writeLeftColumn, 'rightColumn', _writeRightColumn);
}
/**
@@ -74,20 +62,7 @@ class StatsPage extends PageWriter {
*/
void writeStyleSheet(StringSink sink) {
super.writeStyleSheet(sink);
- sink.writeln(r'''
-#leftColumn {
- float: left;
- height: 100%;
- overflow: auto;
- width: 50%;
-}
-#rightColumn {
- float: right;
- height: 100%;
- overflow: auto;
- width: 50%;
-}
-''');
+ writeTwoColumnStyles(sink, 'leftColumn', 'rightColumn');
}
/**
« no previous file with comments | « pkg/analysis_server/tool/instrumentation/page/page_writer.dart ('k') | pkg/analysis_server/tool/instrumentation/server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698