Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2390633002: Rename media switch "flash-join-media-session" to "FlashJoinsMediaSession" (Closed)

Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 2 months ago
Reviewers:
hubbe
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename media switch "flash-join-media-session" to "FlashJoinsMediaSession" It is uncommon to use command-line-switch-style for base::Feature names. This CL fixes the feature name for kFlashJoinsMediaSession. BUG=619084 Committed: https://crrev.com/cac47f309a84b18246251fa11512871bba625dc0 Cr-Commit-Position: refs/heads/master@{#422743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/base/media_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Zhiqiang Zhang (Slow)
4 years, 2 months ago (2016-10-03 10:16:02 UTC) #3
hubbe
LGTM It's not that uncommon, but if you want to rename it, be my guest. ...
4 years, 2 months ago (2016-10-03 17:22:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390633002/1
4 years, 2 months ago (2016-10-03 20:03:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/304268)
4 years, 2 months ago (2016-10-03 23:15:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390633002/1
4 years, 2 months ago (2016-10-04 09:22:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 10:42:54 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 10:44:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cac47f309a84b18246251fa11512871bba625dc0
Cr-Commit-Position: refs/heads/master@{#422743}

Powered by Google App Engine
This is Rietveld 408576698