Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 2390613002: [Bugfix][Editing] Null check in SelectionController::handleGestureLongPress. (Closed)

Created:
4 years, 2 months ago by yoichio
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Null check in SelectionController::handleGestureLongPress. In following CL, I accidentally skipped null check for |innerNode|: https://chromium.googlesource.com/chromium/src/+/66f8f14f5560949660ad6efc0b00484d8342a 15e%5E%21/#F4 This has caused null-ref error. BUG=633073 Committed: https://crrev.com/8afb643438b7e9303d6c74d92087437cbc956f49 Cr-Commit-Position: refs/heads/master@{#422713}

Patch Set 1 #

Total comments: 2

Patch Set 2 : modify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
yosin_UTC9
lgtm w/ small nit https://codereview.chromium.org/2390613002/diff/1/third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html File third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html (right): https://codereview.chromium.org/2390613002/diff/1/third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html#newcode7 third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html:7: assert_true(window.hasOwnProperty('eventSender'), 'this test requires window.eventSender'); ...
4 years, 2 months ago (2016-10-04 03:32:29 UTC) #7
yoichio
4 years, 2 months ago (2016-10-04 03:57:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390613002/20001
4 years, 2 months ago (2016-10-04 03:58:14 UTC) #11
yoichio
https://codereview.chromium.org/2390613002/diff/1/third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html File third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html (right): https://codereview.chromium.org/2390613002/diff/1/third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html#newcode7 third_party/WebKit/LayoutTests/editing/selection/mouse/long-press-on-hidden-node-crash.html:7: assert_true(window.hasOwnProperty('eventSender'), 'this test requires window.eventSender'); On 2016/10/04 03:32:29, Yosi_UTC9 ...
4 years, 2 months ago (2016-10-04 03:58:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 05:26:26 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 05:28:18 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8afb643438b7e9303d6c74d92087437cbc956f49
Cr-Commit-Position: refs/heads/master@{#422713}

Powered by Google App Engine
This is Rietveld 408576698