Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

Issue 2390583002: [WIP] WebFonts cache-aware timeout adaption (Closed)
Patch Set: handle case in RemoteFontFaceSource if cache-aware deactivated in startLoad(), rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
index 61b47c7850574d477ef9884ff14fd704ad6d9155..dd8472e7188137f68b6a9e854d829361503b81e7 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
@@ -137,6 +137,15 @@ bool ResourceLoader::willFollowRedirect(
DCHECK(!passedNewRequest.isNull());
DCHECK(!passedRedirectResponse.isNull());
+ if (m_resource->resourceRequest().isCacheAwareLoadingActivated()) {
+ // Fail as disk cache miss and retry in ResourceFetcher::didFailLoading().
+ WebURLError error;
+ error.reason = 1; // non-zero
kouhei (in TOK) 2016/10/20 10:43:07 Would it be possible to do "error.setIsCacheMiss()
Shao-Chuan Lee 2016/10/21 04:35:02 This WebURLError object will be converted into Res
+ error.isCacheMiss = true;
+ didFail(nullptr, error);
+ return false;
+ }
+
ResourceRequest& newRequest(passedNewRequest.toMutableResourceRequest());
const ResourceResponse& redirectResponse(
passedRedirectResponse.toResourceResponse());

Powered by Google App Engine
This is Rietveld 408576698