[WIP] WebFonts cache-aware timeout adaption

third_party/WebKit/Source/platform/exported/WebURLError.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "public/platform/WebURLError.h"
 
+#include "platform/network/NetworkUtils.h"
 #include "platform/network/ResourceError.h"
 #include "platform/weborigin/KURL.h"
 
 namespace blink {
 
 WebURLError::WebURLError(const ResourceError& error) {
   *this = error;
 }
 
 WebURLError& WebURLError::operator=(const ResourceError& error) {
@@ skipping 15 matching lines @@
   if (!reason)
     return ResourceError();
   ResourceError resourceError = ResourceError(
       domain, reason, unreachableURL.string(), localizedDescription);
   resourceError.setIsCancellation(isCancellation);
   resourceError.setStaleCopyInCache(staleCopyInCache);
   resourceError.setWasIgnoredByHandler(wasIgnoredByHandler);
   return resourceError;
 }
 
+WebURLError WebURLError::cacheMissError() {
+  WebURLError error;
+  error.reason = NetworkUtils::cacheMissErrorCode();

[kinuko, 2016/10/21 10:35:13]

This rather looks a little awkward layering workaround to me, I think we can try
adding deps to net/base/ (or just net/base/net_errors.h to be more specific)
from public/platform or Source/platform and ask Elliott about it.  We wouldn't
want to have uncontrolled dependency but net/base dependency from platform feels
reasonable to me.

[kinuko, 2016/10/22 04:43:01]

Hmm... looking into this a little further, actually I feel adding one more
boolean here was better aligned at least in the current code structure. As you
mentioned somewhere WebURLError's reason code is not meant to be interpreted by
blink and this change is violating it.

I agree that current structure for WebURLError, ResourceError and net error is
more convoluted than necessary and we should probably fix it, but I'd prefer
doing that in a separate, dedicated one-off change.

[Shao-Chuan Lee, 2016/10/25 04:18:20]

I feel like using an enum for mapping from net:: errors we care about should be
better, the existing isCancellation field can also be replaced. ResourceError
will also have to be modified to be consistent.

Adding a new field is a rather simple solution though. kouhei@ WDYT?

+  return error;
+}
+
+bool WebURLError::isCacheMiss() const {
+  return NetworkUtils::isCacheMissErrorCode(reason);
+}
+
 }  // namespace blink