[WIP] WebFonts cache-aware timeout adaption

third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2007 Graham Dennis (graham.dennis@gmail.com)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 119 matching lines @@
     didFail(nullptr, ResourceError::cancelledDueToAccessCheckError(newURL));
 }
 
 bool ResourceLoader::willFollowRedirect(
     WebURLLoader*,
     WebURLRequest& passedNewRequest,
     const WebURLResponse& passedRedirectResponse) {
   DCHECK(!passedNewRequest.isNull());
   DCHECK(!passedRedirectResponse.isNull());
 
+  if (m_resource->resourceRequest().isCacheAwareLoadingActivated()) {
+    // Fail as disk cache miss and retry in ResourceFetcher::didFailLoading().
+    didFail(nullptr, WebURLError::cacheMissError());

[kinuko, 2016/10/22 04:43:01]

nit: I think we'd better create ResourceError here and pass it to didFail?  (See
how other code in this class is calling didFail). WebURLError is an interface
for exposing ResourceError created inside blink to embedders outside blink, and
we're inside blink.

[Shao-Chuan Lee, 2016/10/25 04:18:20]

I've noticed that other places pass ResourceError to didFail(), but it's
converted to WebURLError and back to ResourceError immediately when passing to
ResourceFetcher, I wonder if I should follow existing code.

+    return false;
+  }
+
   ResourceRequest& newRequest(passedNewRequest.toMutableResourceRequest());
   const ResourceResponse& redirectResponse(
       passedRedirectResponse.toResourceResponse());
   newRequest.setRedirectStatus(
       ResourceRequest::RedirectStatus::FollowedRedirect);
 
   const KURL originalURL = newRequest.url();
 
   if (!m_fetcher->willFollowRedirect(m_resource.get(), newRequest,
                                      redirectResponse)) {
@@ skipping 109 matching lines @@
   // a 304, where it will overwrite the cached data we should be reusing.
   if (dataOut.size()) {
     m_fetcher->didReceiveData(m_resource.get(), dataOut.data(), dataOut.size(),
                               encodedDataLength);
     m_resource->setResourceBuffer(dataOut);
   }
   didFinishLoading(0, monotonicallyIncreasingTime(), encodedDataLength);
 }
 
 }  // namespace blink