[WIP] WebFonts cache-aware timeout adaption

content/child/web_url_request_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/web_url_request_util.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 469 matching lines @@
 }
 
 blink::WebURLError CreateWebURLError(const blink::WebURL& unreachable_url,
                                      bool stale_copy_in_cache,
                                      int reason) {
   blink::WebURLError error;
   error.domain = WebString::fromUTF8(net::kErrorDomain);
   error.reason = reason;
   error.unreachableURL = unreachable_url;
   error.staleCopyInCache = stale_copy_in_cache;
+  error.isCacheMiss = reason == net::ERR_CACHE_MISS;

[kouhei (in TOK), 2016/10/20 10:43:07]

Should this be moved to if branches below?
Or would it be possible to add WebURLError::isCacheMiss() query method instead
of keeping the bool?

[Shao-Chuan Lee, 2016/10/21 04:35:02]

It's required to set the field here since WebURLError is in Blink and should not
know about net::ERR_CACHE_MISS.
Moved into if statement.

[kouhei (in TOK), 2016/10/21 05:08:42]

Blink should not know about net::ERR_CACHE_MISS, but can we implement a
predicate method
bool WebURLError::isCacheMiss() const { return reason == net::ERR_CACHE_MISS; }

[Shao-Chuan Lee, 2016/10/21 05:22:17]

This method should be in third_party/WebKit/public/platform/WebURLError.h or
third_party/WebKit/Source/platform/exported/WebURLError.cpp,
I think including net/base/net_errors.h from these places would be a dependency
violation?

[Shao-Chuan Lee, 2016/10/21 06:52:03]

Now having utility methods under blink::NetworkUtils to workaround this. PTAL

   if (reason == net::ERR_ABORTED) {
     error.isCancellation = true;
   } else if (reason == net::ERR_TEMPORARILY_THROTTLED) {
     error.localizedDescription =
         WebString::fromUTF8(kThrottledErrorDescription);
   } else {
     error.localizedDescription =
         WebString::fromUTF8(net::ErrorToString(reason));
   }
   return error;
 }
 
 blink::WebURLError CreateWebURLError(const blink::WebURL& unreachable_url,
                                      bool stale_copy_in_cache,
                                      int reason,
                                      bool was_ignored_by_handler) {
   blink::WebURLError error =
       CreateWebURLError(unreachable_url, stale_copy_in_cache, reason);
   error.wasIgnoredByHandler = was_ignored_by_handler;
   return error;
 }
 
 }  // namespace content