Reland of Prune CreateVisibleSelectionDeprecated from SpellChecker

Reland of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1 id:1 of https://codereview.chromium.org/2383733002/ )

Reason for revert:
The DCHECK is removed, so this patch can be relanded.

Original issue's description:
> Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1 id:1 of https://codereview.chromium.org/2381233003/ )
>
> Reason for revert:
> Causing a lot of editing layout tests to fail by hitting the DCHECK in createVisibleSelection.
>
> Original issue's description:
> > Prune CreateVisibleSelectionDeprecated from SpellChecker
> >
> > BUG=651373
> >
> > Committed: https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1
> > Cr-Commit-Position: refs/heads/master@{#422055}
>
> TBR=yosin@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=651373
>
> Committed: https://crrev.com/008a854391318e289c35c43eeb9b78e1896c30f7
> Cr-Commit-Position: refs/heads/master@{#422079}

TBR=yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651373
Committed: https://crrev.com/6e0721d971f7bfeca41873d76e8fe0959ec6b3f1
Cr-Commit-Position: refs/heads/master@{#422394}

[Xiaocheng, 2016-10-03 04:27:25]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-03 04:27:26]

Created Reland of Prune CreateVisibleSelectionDeprecated from SpellChecker

[commit-bot: I haz the power, 2016-10-03 04:27:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-03 04:36:50]

lgtm

[commit-bot: I haz the power, 2016-10-03 06:02:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 06:02:18]

Failed to apply patch for
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:298
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp' with
conflicts.
  U third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Patch:       third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index
61c6bb3558efb3d6d14385ce09c6dad89aa43f84..20053f42256503e531bb368e8259010941b8cbb9
100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -298,7 +298,7 @@
         // a marker so we draw the red squiggle later.
 
         const EphemeralRange misspellingRange =
calculateCharacterSubrange(EphemeralRange(spellingSearchStart,
spellingSearchEnd), misspellingOffset, misspelledWord.length());
-       
frame().selection().setSelection(createVisibleSelectionDeprecated(misspellingRange));
+       
frame().selection().setSelection(createVisibleSelection(misspellingRange));
         frame().selection().revealSelection();
        
spellCheckerClient().updateSpellingUIWithMisspelledWord(misspelledWord);
        
frame().document()->markers().addMarker(misspellingRange.startPosition(),
misspellingRange.endPosition(), DocumentMarker::Spelling);
@@ -394,7 +394,7 @@
 
     if (cmd.commandTypeOfOpenCommand() ==
TypingCommand::InsertParagraphSeparator) {
         VisiblePosition nextWord = nextWordPosition(start);
-        VisibleSelection words =
createVisibleSelectionDeprecated(wordStartOfPrevious, endOfWord(nextWord));
+        VisibleSelection words = createVisibleSelection(wordStartOfPrevious,
endOfWord(nextWord));
         markMisspellingsAfterLineBreak(words);
         return;
     }
@@ -418,7 +418,7 @@
 {
     TRACE_EVENT0("blink", "SpellChecker::markMisspellingsAfterTypingToWord");
 
-    VisibleSelection adjacentWords =
createVisibleSelectionDeprecated(startOfWord(wordStart, LeftWordIfOnBoundary),
endOfWord(wordStart, RightWordIfOnBoundary));
+    VisibleSelection adjacentWords =
createVisibleSelection(startOfWord(wordStart, LeftWordIfOnBoundary),
endOfWord(wordStart, RightWordIfOnBoundary));
     markMisspellingsAndBadGrammar(adjacentWords);
 }
 
@@ -698,7 +698,7 @@
     EphemeralRange markerRange =
EphemeralRange(Position(caretRange.startPosition().computeContainerNode(),
markers[0]->startOffset()),
Position(caretRange.endPosition().computeContainerNode(),
markers[0]->endOffset()));
     if (markerRange.isNull())
         return;
-   
frame().selection().setSelection(createVisibleSelectionDeprecated(markerRange),
CharacterGranularity);
+    frame().selection().setSelection(createVisibleSelection(markerRange),
CharacterGranularity);
 
     // TODO(xiaochengh): The use of
updateStyleAndLayoutIgnorePendingStylesheets
     // needs to be audited.  See http://crbug.com/590369 for more details.
@@ -760,7 +760,7 @@
         const bool caretBrowsing = frame().settings() &&
frame().settings()->caretBrowsingEnabled();
         if (newSelection.isContentEditable() || caretBrowsing) {
             const VisiblePosition newStart(newSelection.visibleStart());
-            newAdjacentWords =
createVisibleSelectionDeprecated(startOfWord(newStart, LeftWordIfOnBoundary),
endOfWord(newStart, RightWordIfOnBoundary));
+            newAdjacentWords = createVisibleSelection(startOfWord(newStart,
LeftWordIfOnBoundary), endOfWord(newStart, RightWordIfOnBoundary));
         }
     }
 
@@ -816,7 +816,7 @@
     TRACE_EVENT0("blink", "SpellChecker::spellCheckOldSelection");
 
     VisiblePosition oldStart(oldSelection.visibleStart());
-    VisibleSelection oldAdjacentWords =
createVisibleSelectionDeprecated(startOfWord(oldStart, LeftWordIfOnBoundary),
endOfWord(oldStart, RightWordIfOnBoundary));
+    VisibleSelection oldAdjacentWords =
createVisibleSelection(startOfWord(oldStart, LeftWordIfOnBoundary),
endOfWord(oldStart, RightWordIfOnBoundary));
     if (oldAdjacentWords == newAdjacentWords)
         return;
     markMisspellingsAndBadGrammar(oldAdjacentWords);

[Xiaocheng, 2016-10-03 06:05:33]

Whoops, forgot about the clang reformatting...

[Xiaocheng, 2016-10-03 06:09:31]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-03 06:09:32]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2390573002/#ps40001
(title: "Rebased on clang reformatting")

[commit-bot: I haz the power, 2016-10-03 06:09:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 09:04:26]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-03 09:06:14]

Description was changed from

==========
Reland of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1
id:1 of https://codereview.chromium.org/2383733002/ )

Reason for revert:
The DCHECK is removed, so this patch can be relanded.

Original issue's description:
> Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset
#1 id:1 of https://codereview.chromium.org/2381233003/ )
> 
> Reason for revert:
> Causing a lot of editing layout tests to fail by hitting the DCHECK in
createVisibleSelection.
> 
> Original issue's description:
> > Prune CreateVisibleSelectionDeprecated from SpellChecker
> >
> > BUG=651373
> >
> > Committed: https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1
> > Cr-Commit-Position: refs/heads/master@{#422055}
> 
> TBR=yosin@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=651373
> 
> Committed: https://crrev.com/008a854391318e289c35c43eeb9b78e1896c30f7
> Cr-Commit-Position: refs/heads/master@{#422079}

TBR=yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651373
==========

to

==========
Reland of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1
id:1 of https://codereview.chromium.org/2383733002/ )

Reason for revert:
The DCHECK is removed, so this patch can be relanded.

Original issue's description:
> Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset
#1 id:1 of https://codereview.chromium.org/2381233003/ )
>
> Reason for revert:
> Causing a lot of editing layout tests to fail by hitting the DCHECK in
createVisibleSelection.
>
> Original issue's description:
> > Prune CreateVisibleSelectionDeprecated from SpellChecker
> >
> > BUG=651373
> >
> > Committed: https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1
> > Cr-Commit-Position: refs/heads/master@{#422055}
>
> TBR=yosin@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=651373
>
> Committed: https://crrev.com/008a854391318e289c35c43eeb9b78e1896c30f7
> Cr-Commit-Position: refs/heads/master@{#422079}

TBR=yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651373

Committed: https://crrev.com/6e0721d971f7bfeca41873d76e8fe0959ec6b3f1
Cr-Commit-Position: refs/heads/master@{#422394}
==========

[commit-bot: I haz the power, 2016-10-03 09:06:15]

Patchset 2 (id:??) landed as
https://crrev.com/6e0721d971f7bfeca41873d76e8fe0959ec6b3f1
Cr-Commit-Position: refs/heads/master@{#422394}