Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2390553004: [MD settings] remove icons from wallpaper and themes rows; avoid opening theme page on reset (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove icons from wallpaper and themes rows; avoid opening theme page on reset This CL removes the icons from the wallpaper and these rows (I believe that is approved by Alan). This also avoids having the themes page open up when resetting (removing) the current theme. BUG=651715 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a8e914c72b2e6e2d68f56e1f1d48c4f77f964859 Cr-Commit-Position: refs/heads/master@{#422866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +9 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/icons.html View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 2 months ago (2016-10-03 23:51:59 UTC) #4
Dan Beam
lgtm
4 years, 2 months ago (2016-10-04 00:09:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390553004/1
4 years, 2 months ago (2016-10-04 18:34:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 18:39:43 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:44:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8e914c72b2e6e2d68f56e1f1d48c4f77f964859
Cr-Commit-Position: refs/heads/master@{#422866}

Powered by Google App Engine
This is Rietveld 408576698