Set removal milestone in MediaStreamTrack.getSources deprecation message.

Set removal milestone in MediaStreamTrack.getSources deprecation message.

BUG=388194, 649710
Committed: https://crrev.com/2a97db8de8551ccd894bf9e96a3af5481dc44e24
Cr-Commit-Position: refs/heads/master@{#422762}

[Guido Urdaneta, 2016-10-03 10:34:49]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 10:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 11:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 11:20:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Guido Urdaneta, 2016-10-03 12:34:30]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 12:34:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2016-10-03 13:55:56]

Description was changed from

==========
Set removal milestone in MediaStreamTrack.getSources deprecation message.

BUG=388194,649710
==========

to

==========
Set removal milestone in MediaStreamTrack.getSources deprecation message.

BUG=388194,649710
==========

[Guido Urdaneta, 2016-10-03 13:55:56]

guidou@chromium.org changed reviewers:
+ foolip@chromium.org

[Guido Urdaneta, 2016-10-03 13:56:13]

Hi, PTAL

[Guido Urdaneta, 2016-10-03 13:56:23]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-03 15:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 15:58:17]

Dry run: This issue passed the CQ dry run.

[foolip, 2016-10-03 16:20:07]

LGTM. As discussed on blink-dev, I think it'd be helpful to paste an
implementation of MediaStreamTrack.getSources in terms of enumerate devices in a
bug comment and link to that in the chromestatus entry, for any developers who
have to fix this but didn't necessarily write the original code.

[Guido Urdaneta, 2016-10-03 16:23:31]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-10-03 16:23:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 16:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 16:28:49]

Failed to apply patch for third_party/WebKit/Source/core/frame/Deprecation.cpp:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/Deprecation.cpp:348
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/frame/Deprecation.cpp' with
conflicts.
  U third_party/WebKit/Source/core/frame/Deprecation.cpp

Patch:       third_party/WebKit/Source/core/frame/Deprecation.cpp
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp
b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index
4470ec0a42e279a6216d354380d0b539dd066f07..55be953a4e051d6bbb91e7e84398bb240194120f
100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -348,7 +348,7 @@ String Deprecation::deprecationMessage(UseCounter::Feature
feature)
         return replacedBy("'Performance.onwebkitresourcetimingbufferfull'",
"'Performance.onresourcetimingbufferfull'");
 
     case UseCounter::MediaStreamTrackGetSources:
-        return "MediaStreamTrack.getSources is deprecated. See
https://www.chromestatus.com/feature/4765305641369600 for more details.";
+        return willBeRemoved("MediaStreamTrack.getSources", M56,
"4765305641369600");
 
     case UseCounter::WebAnimationHyphenatedProperty:
         return "Hyphenated property names in Web Animations keyframes are
invalid and therefore ignored. Please use camelCase instead.";

[Guido Urdaneta, 2016-10-04 08:18:30]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-10-04 08:18:30]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2390553003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-04 08:18:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 10:55:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 10:55:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Guido Urdaneta, 2016-10-04 10:56:09]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-10-04 10:56:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 12:11:47]

Description was changed from

==========
Set removal milestone in MediaStreamTrack.getSources deprecation message.

BUG=388194,649710
==========

to

==========
Set removal milestone in MediaStreamTrack.getSources deprecation message.

BUG=388194,649710
==========

[commit-bot: I haz the power, 2016-10-04 12:11:48]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-04 12:15:21]

Description was changed from

==========
Set removal milestone in MediaStreamTrack.getSources deprecation message.

BUG=388194,649710
==========

to

==========
Set removal milestone in MediaStreamTrack.getSources deprecation message.

BUG=388194,649710

Committed: https://crrev.com/2a97db8de8551ccd894bf9e96a3af5481dc44e24
Cr-Commit-Position: refs/heads/master@{#422762}
==========

[commit-bot: I haz the power, 2016-10-04 12:15:22]

Patchset 2 (id:??) landed as
https://crrev.com/2a97db8de8551ccd894bf9e96a3af5481dc44e24
Cr-Commit-Position: refs/heads/master@{#422762}