Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

Issue 2390543002: Reflow comments in core/dom/. (Closed)
Patch Set: Reformat comments in core/dom/. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
diff --git a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
index 79c6de122671e36534f6b047d442deb62c229d56..8044c7f8b83101124fc07e65861fe2f281fd770c 100644
--- a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
+++ b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
@@ -28,24 +28,25 @@ namespace {
// Saturate the length of a paragraph to save time.
const int kTextContentLengthSaturation = 1000;
-// Filter out short P elements. The threshold is set to around 2 English sentences.
+// Filter out short P elements. The threshold is set to around 2 English
+// sentences.
const unsigned kParagraphLengthThreshold = 140;
// Saturate the scores to save time. The max is the score of 6 long paragraphs.
-const double kMozScoreSaturation =
- 175.954539583; // 6 * sqrt(kTextContentLengthSaturation - kParagraphLengthThreshold)
-const double kMozScoreAllSqrtSaturation =
- 189.73665961; // 6 * sqrt(kTextContentLengthSaturation);
+// 6 * sqrt(kTextContentLengthSaturation - kParagraphLengthThreshold)
+const double kMozScoreSaturation = 175.954539583;
+// 6 * sqrt(kTextContentLengthSaturation);
+const double kMozScoreAllSqrtSaturation = 189.73665961;
const double kMozScoreAllLinearSaturation = 6 * kTextContentLengthSaturation;
unsigned textContentLengthSaturated(const Element& root) {
unsigned length = 0;
- // This skips shadow DOM intentionally, to match the JavaScript implementation.
- // We would like to use the same statistics extracted by the JavaScript implementation
- // on iOS, and JavaScript cannot peek deeply into shadow DOM except on modern Chrome
- // versions.
- // Given shadow DOM rarely appears in <P> elements in long-form articles, the overall
- // accuracy should not be largely affected.
+ // This skips shadow DOM intentionally, to match the JavaScript
+ // implementation. We would like to use the same statistics extracted by the
+ // JavaScript implementation on iOS, and JavaScript cannot peek deeply into
+ // shadow DOM except on modern Chrome versions.
+ // Given shadow DOM rarely appears in <P> elements in long-form articles, the
+ // overall accuracy should not be largely affected.
for (Node& node : NodeTraversal::inclusiveDescendantsOf(root)) {
if (!node.isTextNode()) {
continue;
@@ -208,7 +209,8 @@ WebDistillabilityFeatures DocumentStatisticsCollector::collectStatistics(
double startTime = monotonicallyIncreasingTime();
- // This should be cheap since collectStatistics is only called right after layout.
+ // This should be cheap since collectStatistics is only called right after
+ // layout.
document.updateStyleAndLayoutTree();
// Traverse the DOM tree and collect statistics.

Powered by Google App Engine
This is Rietveld 408576698