Issue 239053007: Always pass in code to NewFunctionWithoutPrototype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239053007: Always pass in code to NewFunctionWithoutPrototype (Closed)

Created:
6 years, 8 months ago by Toon Verwaest

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Always pass in code to NewFunctionWithoutPrototype BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20842

Patch Set 3 : Addressed comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -29 lines)			Patch
M	src/bootstrapper.cc	View	1 2	2 chunks	+4 lines, -10 lines	0 comments	Download
M	src/factory.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/factory.cc	View		2 chunks	+4 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/239053007/diff/2/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/239053007/diff/2/src/bootstrapper.cc#newcode487 src/bootstrapper.cc:487: Handle<Code> code = I think ...

6 years, 8 months ago (2014-04-17 11:16:23 UTC) #2

Toon Verwaest

6 years, 8 months ago (2014-04-17 11:57:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r20842 (presubmit successful).

Expand Messages | Collapse Messages

Issue 239053007: Always pass in code to NewFunctionWithoutPrototype (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Addressed comment #

Messages