Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 239053005: Broker process unittest build fail after r263147 (Closed)

Created:
6 years, 8 months ago by elecro
Modified:
6 years, 8 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Broker process unittest build fail after r263147 After the r263147 the unittest build for the broker process fails with unknown type error. Add the missing include which defines the type. BUG=364058 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sandbox/linux/services/broker_process_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
elecro
The CL https://codereview.chromium.org/229893002 uses types from the sys/resource.h. This patch will add the missing include.
6 years, 8 months ago (2014-04-16 15:04:10 UTC) #1
jln (very slow on Chromium)
Thanks, lgtm
6 years, 8 months ago (2014-04-16 15:57:11 UTC) #2
mdempsky
lgtm oops, I thought I added that header :(
6 years, 8 months ago (2014-04-16 17:13:09 UTC) #3
elecro
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
6 years, 8 months ago (2014-04-17 11:16:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/239053005/1
6 years, 8 months ago (2014-04-17 11:16:33 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 14:29:56 UTC) #6
Message was sent while issue was closed.
Change committed as 264505

Powered by Google App Engine
This is Rietveld 408576698