Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: rlz/lib/lib_values.cc

Issue 239053004: Use invalid value for GetAccessPointName for CHROME_IOS_RESERVED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding unittests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | rlz/lib/lib_values_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/lib/lib_values.cc
diff --git a/rlz/lib/lib_values.cc b/rlz/lib/lib_values.cc
index 06113a8fc9277a0ef821e2de7a71e890899c4083..80e987af23b2189de2aac66ac9baaf5994b862e3 100644
--- a/rlz/lib/lib_values.cc
+++ b/rlz/lib/lib_values.cc
@@ -99,7 +99,10 @@ const char* GetAccessPointName(AccessPoint point) {
case CHROMEOS_HOME_PAGE: return "CB";
case CHROMEOS_APP_LIST: return "CC";
case CHROME_IOS_OMNIBOX: return "C9";
- case CHROME_IOS_RESERVED: return "C0";
+ // Returns an invalid access point value here as this value does not
+ // correspond to a defined access point, but need to be defined for
+ // code that iterates over all values of rlz_lib::AccessPoint.
+ case CHROME_IOS_RESERVED: return "__";
case CHROME_APP_LIST: return "C7";
case CHROME_MAC_APP_LIST: return "C8";
case UNDEFINED_AP_Q: return "RQ";
« no previous file with comments | « no previous file | rlz/lib/lib_values_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698