rlz/lib/lib_values.cc - Issue 239053004: Use invalid value for GetAccessPointName for CHROME_IOS_RESERVED

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: rlz/lib/lib_values.cc

Issue 239053004: Use invalid value for GetAccessPointName for CHROME_IOS_RESERVED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding unittests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Key and value names of the location of the RLZ shared state.	5 // Key and value names of the location of the RLZ shared state.

6	6

7 #include "rlz/lib/lib_values.h"	7 #include "rlz/lib/lib_values.h"

8	8

9 #include "base/strings/stringprintf.h"	9 #include "base/strings/stringprintf.h"

10 #include "rlz/lib/assert.h"	10 #include "rlz/lib/assert.h"

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92 case PARTNER_AP_2: return "V2";	92 case PARTNER_AP_2: return "V2";

93 case PARTNER_AP_3: return "V3";	93 case PARTNER_AP_3: return "V3";

94 case PARTNER_AP_4: return "V4";	94 case PARTNER_AP_4: return "V4";

95 case PARTNER_AP_5: return "V5";	95 case PARTNER_AP_5: return "V5";

96 case CHROME_MAC_OMNIBOX: return "C5";	96 case CHROME_MAC_OMNIBOX: return "C5";

97 case CHROME_MAC_HOME_PAGE: return "C6";	97 case CHROME_MAC_HOME_PAGE: return "C6";

98 case CHROMEOS_OMNIBOX: return "CA";	98 case CHROMEOS_OMNIBOX: return "CA";

99 case CHROMEOS_HOME_PAGE: return "CB";	99 case CHROMEOS_HOME_PAGE: return "CB";

100 case CHROMEOS_APP_LIST: return "CC";	100 case CHROMEOS_APP_LIST: return "CC";

101 case CHROME_IOS_OMNIBOX: return "C9";	101 case CHROME_IOS_OMNIBOX: return "C9";

102 case CHROME_IOS_RESERVED: return "C0";	102 // Returns an invalid access point value here as this value does not

	103 // correspond to a defined access point, but need to be defined for

	104 // code that iterates over all values of rlz_lib::AccessPoint.

	105 case CHROME_IOS_RESERVED: return "__";

103 case CHROME_APP_LIST: return "C7";	106 case CHROME_APP_LIST: return "C7";

104 case CHROME_MAC_APP_LIST: return "C8";	107 case CHROME_MAC_APP_LIST: return "C8";

105 case UNDEFINED_AP_Q: return "RQ";	108 case UNDEFINED_AP_Q: return "RQ";

106 case UNDEFINED_AP_R: return "RR";	109 case UNDEFINED_AP_R: return "RR";

107 case UNDEFINED_AP_S: return "RS";	110 case UNDEFINED_AP_S: return "RS";

108 case UNDEFINED_AP_T: return "RT";	111 case UNDEFINED_AP_T: return "RT";

109 case UNDEFINED_AP_U: return "RU";	112 case UNDEFINED_AP_U: return "RU";

110 case UNDEFINED_AP_V: return "RV";	113 case UNDEFINED_AP_V: return "RV";

111 case UNDEFINED_AP_W: return "RW";	114 case UNDEFINED_AP_W: return "RW";

112 case UNDEFINED_AP_X: return "RX";	115 case UNDEFINED_AP_X: return "RX";

(...skipping 86 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
199 case WEBAPPS: return "W";	202 case WEBAPPS: return "W";

200 case PINYIN_IME: return "N";	203 case PINYIN_IME: return "N";

201 case PARTNER: return "V";	204 case PARTNER: return "V";

202 }	205 }

203	206

204 ASSERT_STRING("GetProductName: Unknown Product");	207 ASSERT_STRING("GetProductName: Unknown Product");

205 return "";	208 return "";

206 }	209 }

207	210

208 } // namespace rlz_lib	211 } // namespace rlz_lib

OLD	NEW

« no previous file with comments | « no previous file | rlz/lib/lib_values_unittest.cc » ('j') | no next file with comments »