Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2390513002: Fix potential crashes in setHasHorizontal/VerticalScrollbar. (Closed)

Created:
4 years, 2 months ago by Eric Seckler
Modified:
4 years, 2 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, ajha
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix potential crashes in setHasHorizontal/VerticalScrollbar. Overlooked the possibility for m_frame->settings() to be null during destruction, see crash reports in the bug below. BUG=652089 Committed: https://crrev.com/3dbe3f2b9597110d90ed86f0c50900146f83658e Cr-Commit-Position: refs/heads/master@{#422492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eric Seckler
PTAL asap. Thanks (and sorry..)!
4 years, 2 months ago (2016-10-02 08:56:23 UTC) #3
skobes
lgtm
4 years, 2 months ago (2016-10-03 18:09:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390513002/1
4 years, 2 months ago (2016-10-03 18:22:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 19:33:20 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:34:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dbe3f2b9597110d90ed86f0c50900146f83658e
Cr-Commit-Position: refs/heads/master@{#422492}

Powered by Google App Engine
This is Rietveld 408576698