Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 23905003: Tests: Rename a gyptest*.gyp file to gyptest*.py. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Tests: Rename a gyptest*.gyp file to gyptest*.py. The test runner silently runs gyptest*.gyp files if invoked with a single test, but doesn't run them when asked to run all tests. This test happens to still pass, so rename it so that the bots will check that it keeps passing. R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -27 lines) Patch
D test/mac/gyptest-postbuild-static-library.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
A + test/mac/gyptest-postbuild-static-library.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
`find test -name 'gyptest*' | grep -v .py` finds one other case, which is broken ...
7 years, 3 months ago (2013-09-03 18:03:49 UTC) #1
Mark Mentovai
LGTM
7 years, 3 months ago (2013-09-03 18:04:50 UTC) #2
Nico
7 years, 3 months ago (2013-09-03 18:09:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698