Move IsRunningOnChromeOS to SysInfo

Move IsRunningOnChromeOS to SysInfo
Also, use lsb-release/CHROMEOS_RELEASE_NAME instead of the
USER env variable.

This CL depends on https://codereview.chromium.org/23588009/

BUG=270135
For trivial base/ changes:

R=derat@chromium.org, satorux@chromium.org, sky@chromium.org
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225761

[stevenjb, 2013-09-24 00:19:26]

Other than the changes to base/sys_info, this is mostly just
chromeos::IsRunningOnChromeOS -> SysInfo::IsRunningOnChromeOS

[satorux1, 2013-09-24 04:09:00]

LGTM with nits

https://codereview.chromium.org/23904025/diff/8001/base/sys_info_chromeos.cc
File base/sys_info_chromeos.cc (right):

https://codereview.chromium.org/23904025/diff/8001/base/sys_info_chromeos.cc#...
base/sys_info_chromeos.cc:31: static const char* kChromeOsReleaseNameKey =
"CHROMEOS_RELEASE_NAME";
nit: 'static' is unnecessary.

const char kChromeOsReleaseNameKey[] = "..."

is more efficient per http://udrepper.livejournal.com/13851.html

https://codereview.chromium.org/23904025/diff/8001/base/sys_info_chromeos.cc#...
base/sys_info_chromeos.cc:138: for (size_t i = 0; i <
kChromeOsReleaseNamesLength; ++i) {
remove kChromeOsReleaseNamesLength?

arraysize(kChromeOsReleaseNames) seems to be easier to read.

[Daniel Erat, 2013-09-24 15:45:09]

lgtm

https://codereview.chromium.org/23904025/diff/8001/base/sys_info.h
File base/sys_info.h (right):

https://codereview.chromium.org/23904025/diff/8001/base/sys_info.h#newcode99
base/sys_info.h:99: // Returns true when actually running in a ChromeOS
environment.
nit: s/ChromeOS/Chrome OS/

[stevenjb, 2013-09-26 22:07:36]

https://codereview.chromium.org/23904025/diff/8001/base/sys_info.h
File base/sys_info.h (right):

https://codereview.chromium.org/23904025/diff/8001/base/sys_info.h#newcode99
base/sys_info.h:99: // Returns true when actually running in a ChromeOS
environment.
On 2013/09/24 15:45:11, Daniel Erat wrote:
> nit: s/ChromeOS/Chrome OS/

Done.

https://codereview.chromium.org/23904025/diff/8001/base/sys_info_chromeos.cc
File base/sys_info_chromeos.cc (right):

https://codereview.chromium.org/23904025/diff/8001/base/sys_info_chromeos.cc#...
base/sys_info_chromeos.cc:31: static const char* kChromeOsReleaseNameKey =
"CHROMEOS_RELEASE_NAME";
On 2013/09/24 04:09:01, satorux1 wrote:
> nit: 'static' is unnecessary.
> 
> const char kChromeOsReleaseNameKey[] = "..."
> 
> is more efficient per http://udrepper.livejournal.com/13851.html
Oops, thanks for catching. Done.

https://codereview.chromium.org/23904025/diff/8001/base/sys_info_chromeos.cc#...
base/sys_info_chromeos.cc:138: for (size_t i = 0; i <
kChromeOsReleaseNamesLength; ++i) {
On 2013/09/24 04:09:01, satorux1 wrote:
> remove kChromeOsReleaseNamesLength?
> 
> arraysize(kChromeOsReleaseNames) seems to be easier to read.

Done.

[stevenjb, 2013-09-26 22:10:35]

+brettw@chromium.org for base/ OWNER

[stevenjb, 2013-09-26 22:13:09]

+brettw@chromium.org for base/ OWNER
+sky@ for for ui/ and chrome/ non-chromeos subdirectory OWNER

[sky, 2013-09-26 22:15:56]

LGTM - Feel free to TBR this sort of change in the future.

[stevenjb, 2013-09-26 22:16:24]

On 2013/09/26 22:13:09, stevenjb wrote:
> mailto:+brettw@chromium.org for base/ OWNER
> +sky@ for for ui/ and chrome/ non-chromeos subdirectory OWNER

Note: OWNER reviews only needed for

bretw@
    base/base.gypi
    base/chromeos/chromeos_version.cc
    base/chromeos/chromeos_version.h
    base/file_util_posix.cc
    base/sys_info.h
    base/sys_info_chromeos.cc
    base/sys_info_unittest.cc

sky@
    chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc
    chrome/browser/extensions/api/terminal/terminal_private_api.cc
    chrome/browser/lifetime/application_lifetime.cc
    chrome/browser/net/chrome_network_delegate.cc
    chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
    chrome/browser/ui/webui/flags_ui.cc
    chrome/browser/usb/usb_device.cc
    content/browser/aura/image_transport_factory.cc
    content/public/test/browser_test_base.cc
    ui/aura/root_window_host_x11.cc
    ui/base/ime/input_method_ibus.cc
    ui/base/ime/input_method_initializer.cc
    ui/compositor/compositor.cc

Thanks!

[stevenjb, 2013-09-27 19:28:41]

Committed patchset #6 manually as r225761 (presubmit successful).