Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: tests/corelib/uri_http_test.dart

Issue 23904004: Accept IPv6 addresses in Uri.http and Uri.https, and correctly nest IPv6 addresses in '[' and ']'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixing comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-co19.status ('k') | tests/corelib/uri_ipv4_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/uri_http_test.dart
diff --git a/tests/corelib/uri_http_test.dart b/tests/corelib/uri_http_test.dart
index 354e0529f01526da1a6feb00261de4ebf6e9960d..95614f7913b3e29afb4d0cd229bd050a4c0ada93 100644
--- a/tests/corelib/uri_http_test.dart
+++ b/tests/corelib/uri_http_test.dart
@@ -31,6 +31,8 @@ testHttpUri() {
check(new Uri.http("host", "/a/b", { "c": "d" }), "http://host/a/b?c=d");
check(new Uri.http("host",
"/a/b", { "c=": "&d" }), "http://host/a/b?c%3D=%26d");
+ check(new Uri.http("[::]", "a"), "http://[::]/a");
+ check(new Uri.http("[::127.0.0.1]", "a"), "http://[::127.0.0.1]/a");
}
testHttpsUri() {
@@ -60,6 +62,8 @@ testHttpsUri() {
check(new Uri.https("host", "/a/b", { "c": "d" }), "https://host/a/b?c=d");
check(new Uri.https("host",
"/a/b", { "c=": "&d" }), "https://host/a/b?c%3D=%26d");
+ check(new Uri.https("[::]", "a"), "https://[::]/a");
+ check(new Uri.https("[::127.0.0.1]", "a"), "https://[::127.0.0.1]/a");
}
main() {
« no previous file with comments | « tests/co19/co19-co19.status ('k') | tests/corelib/uri_ipv4_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698