Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2390393002:
[wasm] tracing for wasm module instances (Closed)
|
Created:
4 years, 2 months ago by Mircea Trofin Modified:
4 years, 2 months ago Reviewers:
bradnelson CC:
v8-reviews_googlegroups.com, Michael Hablich Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] tracing for wasm module instances
Debug-time tracing for module instances, to aid diagnosing
potential bugs.
BUG=
Committed: https://crrev.com/fa5b221ec7220bdee490044bed9b37907d9746f7
Cr-Commit-Position: refs/heads/master@{#39965}
Patch Set 1 #Patch Set 2 : just tracing #Patch Set 3 : just tracing #Patch Set 4 : [wasm] tracing for wasm module instances #
Messages
Total messages: 29 (23 generated)
Description was changed from ========== [wasm] tracing for wasm module instances BUG= ========== to ========== [wasm] tracing for wasm module instances Debug-time tracing for module instances, to aid diagnosing potential bugs. BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/15510)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/15442)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2390393002/#ps60001 (title: "[wasm] tracing for wasm module instances")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] tracing for wasm module instances Debug-time tracing for module instances, to aid diagnosing potential bugs. BUG= ========== to ========== [wasm] tracing for wasm module instances Debug-time tracing for module instances, to aid diagnosing potential bugs. BUG= ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] tracing for wasm module instances Debug-time tracing for module instances, to aid diagnosing potential bugs. BUG= ========== to ========== [wasm] tracing for wasm module instances Debug-time tracing for module instances, to aid diagnosing potential bugs. BUG= Committed: https://crrev.com/fa5b221ec7220bdee490044bed9b37907d9746f7 Cr-Commit-Position: refs/heads/master@{#39965} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/fa5b221ec7220bdee490044bed9b37907d9746f7 Cr-Commit-Position: refs/heads/master@{#39965} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
