Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2390383002: Revert of skpbench: add option for gpu timing (Closed)

Created:
4 years, 2 months ago by mtklein_C
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of skpbench: add option for gpu timing (patchset #7 id:120001 of https://codereview.chromium.org/2388433003/ ) Reason for revert: many bots failing Original issue's description: > skpbench: add option for gpu timing > > Adds a gpu timing option with a GL implementation. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003 > > Committed: https://skia.googlesource.com/skia/+/c06720d06faab3b01eba1b8693e0ac791f06dc96 TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/56df2de7fb48e879446938f47464c7a2c8223616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -380 lines) Patch
M tools/gpu/FenceSync.h View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/gpu/GpuTimer.h View 1 chunk +0 lines, -77 lines 0 comments Download
M tools/gpu/TestContext.h View 3 chunks +1 line, -8 lines 0 comments Download
M tools/gpu/TestContext.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M tools/gpu/gl/GLTestContext.cpp View 3 chunks +0 lines, -130 lines 0 comments Download
M tools/skpbench/_benchresult.py View 3 chunks +1 line, -4 lines 0 comments Download
M tools/skpbench/parseskpbench.py View 3 chunks +37 lines, -54 lines 0 comments Download
M tools/skpbench/skpbench.cpp View 12 chunks +21 lines, -88 lines 0 comments Download
M tools/skpbench/skpbench.py View 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein_C
Created Revert of skpbench: add option for gpu timing
4 years, 2 months ago (2016-10-04 19:49:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390383002/1
4 years, 2 months ago (2016-10-04 19:49:41 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 19:49:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56df2de7fb48e879446938f47464c7a2c8223616

Powered by Google App Engine
This is Rietveld 408576698