Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: tracing/tracing/extras/importer/v8/log_reader.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: more changes from code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/extras/importer/v8/codemap.html ('k') | tracing/tracing/extras/importer/v8/splaytree.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/extras/importer/v8/log_reader.html
diff --git a/tracing/tracing/extras/importer/v8/log_reader.html b/tracing/tracing/extras/importer/v8/log_reader.html
index 9b10ab69b96963e640a3aa6bbe280678cd4ca30c..5856237ed3187a914a668e55ad230c0a2d0f0752 100644
--- a/tracing/tracing/extras/importer/v8/log_reader.html
+++ b/tracing/tracing/extras/importer/v8/log_reader.html
@@ -15,7 +15,7 @@ tr.exportTo('tr.e.importer.v8', function() {
/**
* Creates a CSV lines parser.
*/
- function CsvParser() { };
+ function CsvParser() { }
/**
* A regex for matching a CSV field.
@@ -84,7 +84,7 @@ tr.exportTo('tr.e.importer.v8', function() {
* @type {CsvParser}
*/
this.csvParser_ = new CsvParser();
- };
+ }
/**
* Used for printing error messages.
@@ -127,12 +127,12 @@ tr.exportTo('tr.e.importer.v8', function() {
for (var i = 0, n = stack.length; i < n; ++i) {
var frame = stack[i];
var firstChar = frame.charAt(0);
- if (firstChar == '+' || firstChar == '-') {
+ if (firstChar === '+' || firstChar === '-') {
// An offset from the previous frame.
prevFrame += parseInt(frame, 16);
fullStack.push(prevFrame);
// Filter out possible 'overflow' string.
- } else if (firstChar != 'o') {
+ } else if (firstChar !== 'o') {
fullStack.push(parseInt(frame, 16));
}
}
@@ -172,7 +172,7 @@ tr.exportTo('tr.e.importer.v8', function() {
var parser = dispatch.parsers[i];
if (parser === null) {
parsedFields.push(fields[1 + i]);
- } else if (typeof parser == 'function') {
+ } else if (typeof parser === 'function') {
parsedFields.push(parser(fields[1 + i]));
} else {
// var-args
« no previous file with comments | « tracing/tracing/extras/importer/v8/codemap.html ('k') | tracing/tracing/extras/importer/v8/splaytree.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698